Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/189
Ok, email us at private@ and let's figure this out. Ready to merge now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/188
@synhershko
> I say let's first release, then see who uses this. Once we see a lot of
usage, we may reconsider the implementation. WDYT?
In that case this is ready to go.
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/185
At some point I looked at WeakDictionary as a replacement but didn't go
forward with it because of some behavior mismatch. Can't really remember now
exactly what it was. If you are certain
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/187
Great job, merging this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user eladmarg commented on the issue:
https://github.com/apache/lucenenet/pull/188
there are few files of the LurchTable, so all we need is @csharptest
permission, and then we can just copy them to the solution and fork the
relevant parts.
I think if we'll contact
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/186
Okay, this one has rebased successfully without any issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/189
Yep, definitely a smaller diff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/189
I haven't tried pushing to the repo, but it doesn't look like I have
permissions in the GitHub control panel to merge pull requests.
It should only take a couple of minutes to fix
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/189
The github interface doesn't reflect on your permissions - please try and
let us know if it doesn't work.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user csharptest commented on the issue:
https://github.com/apache/lucenenet/pull/188
I have no problem with this. Feel free to extract it. You can probably
leave the interfaces behind if you don't need them.
-- Roger
ro...@csharptest.com
>
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/189
Nope, I have permissions issues:
```
F:\Projects\lucenenet>git push upstream master
Enter passphrase for key '/c/Users/Shad/.ssh/id_rsa':
ERROR: Sorry, but @apache has
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/188
> A plain old generic Dictionary works fine, but may use more RAM than the
designers intended.
I am totally okay with that. We should aim to get something out the door
asap, and then
15 matches
Mail list logo
