[jira] [Commented] (LUCENENET-565) Port Lucene.Net.Replicator

2017-08-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120477#comment-16120477 ] ASF GitHub Bot commented on LUCENENET-565: -- Github user NightOwl888 commented on the issue:

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 > Holy crap... I am glad I am not under that umbrella, in an age of continuous delivery and continuous deployment that sounds like poison... o.O... It's both a blessing and a curse.

[jira] [Comment Edited] (LUCENENET-469) Convert Java Iterator classes to implement IEnumerable

2017-08-09 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120444#comment-16120444 ] Andy Pook edited comment on LUCENENET-469 at 8/9/17 6:44 PM: - Yes, agreed.

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-08-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 During the building of a tool to get the `.html` pages converted, I can break the types of links we have into 3 categories: 1. Code links 2. Repo links 3. Namespace links

[jira] [Commented] (LUCENENET-565) Port Lucene.Net.Replicator

2017-08-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119549#comment-16119549 ] ASF GitHub Bot commented on LUCENENET-565: -- Github user jeme commented on the issue:

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-09 Thread jeme
Github user jeme commented on the issue: https://github.com/apache/lucenenet/pull/209 Ok so I think I will give up on commenting on all of the above because there is to much. I will as a general note say be careful that you don't get ahead of your self. I personally think it

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-08-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 BTW - I tried running the code generation after copying and pasting the repo over to a different directory, and I am getting a null reference exception for some reason. ``` Done

[jira] [Commented] (LUCENENET-469) Convert Java Iterator classes to implement IEnumerable

2017-08-09 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119630#comment-16119630 ] Andy Pook commented on LUCENENET-469: - So I have a little time to get into this then :) Probably

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 Jens, thanks for the feedback. While I generally agree with your points, we are unfortunately obligated to work within the confines of the Apache organization, which comes with its

[jira] [Commented] (LUCENENET-565) Port Lucene.Net.Replicator

2017-08-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119708#comment-16119708 ] ASF GitHub Bot commented on LUCENENET-565: -- Github user NightOwl888 commented on the issue:

[jira] [Commented] (LUCENENET-469) Convert Java Iterator classes to implement IEnumerable

2017-08-09 Thread Shad Storhaug (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120627#comment-16120627 ] Shad Storhaug commented on LUCENENET-469: - {quote}It's this Enum class I was calling the

[jira] [Commented] (LUCENENET-565) Port Lucene.Net.Replicator

2017-08-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120626#comment-16120626 ] ASF GitHub Bot commented on LUCENENET-565: -- Github user jeme commented on the issue:

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-09 Thread jeme
Github user jeme commented on the issue: https://github.com/apache/lucenenet/pull/209 > It sounds like you are not too familiar with dependency injection (which is why I am following this approach), and although you can certainly get by without it, it is definitely something every

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 > I don't know how you would get that idea? I have been usiing IoC/DI for years, often but not always paired with a IoC Container. My bad. To me it seems natural to want to put all of

[jira] [Comment Edited] (LUCENENET-469) Convert Java Iterator classes to implement IEnumerable

2017-08-09 Thread Shad Storhaug (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120295#comment-16120295 ] Shad Storhaug edited comment on LUCENENET-469 at 8/9/17 5:28 PM: -

[jira] [Commented] (LUCENENET-469) Convert Java Iterator classes to implement IEnumerable

2017-08-09 Thread Shad Storhaug (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120295#comment-16120295 ] Shad Storhaug commented on LUCENENET-469: - Ahh...I think I now know where we are getting our

[jira] [Comment Edited] (LUCENENET-469) Convert Java Iterator classes to implement IEnumerable

2017-08-09 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120064#comment-16120064 ] Andy Pook edited comment on LUCENENET-469 at 8/9/17 3:22 PM: - Yeah, well, I

[jira] [Commented] (LUCENENET-469) Convert Java Iterator classes to implement IEnumerable

2017-08-09 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120064#comment-16120064 ] Andy Pook commented on LUCENENET-469: - Yeah, well, I thought, that's looks like it might be