[GitHub] lucenenet pull request: FastFacetedSearch (MultiStringIndex Mult...

2015-01-09 Thread NightOwl888
Github user NightOwl888 commented on the pull request: https://github.com/apache/lucenenet/pull/9#issuecomment-69432396 In case anyone needs faceted search before Lucene.Net 4.8 is available, I have just completed a .NET port of version 3.2.0 of the BoboBrowse faceted search engine

[GitHub] lucenenet issue #173: Analysis work

2016-08-02 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/173 Is anyone working on Analysis now? I would like to take a stab at making the StandardAnalyzer and its ~20 dependencies compile. --- If your project is set up for it, you can reply

[GitHub] lucenenet issue #178: Ported Core.Codecs.Perfield.TestPerFieldPostingsFormat...

2016-08-12 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/178 Not sure if that dependency was there or not in the original, but in a more recent commit I have removed the JavaCompatibility namespace entirely so that line has also been removed. Just

[GitHub] lucenenet issue #175: IndexableField API Consistency Fix

2016-08-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/175 I thought I got everything, but I will take another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] lucenenet pull request #176: Ported QueryParser

2016-08-06 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/176#discussion_r73793556 --- Diff: src/Lucene.Net.Core/Util/ToStringUtils.cs --- @@ -36,12 +37,13 @@ public static string Boost(float boost

[GitHub] lucenenet issue #173: Analysis work

2016-08-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/173 FYI - I am still working on this. I managed to get past the infinite recursion problem. I have completed nearly all of the standard and core namespaces and ported over 250 tests, with 225

[GitHub] lucenenet issue #176: Ported QueryParser

2016-08-07 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/176 Another correction - the Lucene.Net 3.0.3 code had a bug. When passing `0`, it would format the boost as `^.0`, but if you passed `0.123` you would get `^0.123`. I checked through

[GitHub] lucenenet issue #176: Ported QueryParser

2016-08-07 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/176 > This is usually where we put all .NET specific stuff that is required by Core / subprojects: > https://github.com/apache/lucenenet/tree/master/src/Lucene.Net.Core/Support/Compati

[GitHub] lucenenet issue #175: IndexableField API Consistency Fix

2016-08-07 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/175 Ok, I did a search of all of the files in this project for these method names. I only found one other file that referenced any of these fields, and it was in a project that (apparently

[GitHub] lucenenet pull request #178: Ported Core.Codecs.Perfield.TestPerFieldPosting...

2016-08-07 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/178 Ported Core.Codecs.Perfield.TestPerFieldPostingsFormat2 Ported the Core.Codecs.Perfield.TestPerFieldPostingsFormat2 tests and removed [Test] attribute from a couple of methods where

[GitHub] lucenenet issue #176: Ported QueryParser

2016-08-08 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/176 Ok, I have moved the test to Lucene.Net.Tests/core/Support. Apparently there *was* a directory with this name, but it had been removed from the project. Not sure what the reasoning

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2017-02-08 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 Hi @conniey, I am starting to go through the tests now on the #203 branch to see if I can fix some of them. However, I can't seem to work out how to turn on verbosity. This used

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2017-02-08 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 To be clear, this happens when you check the DEBUG box in the `Lucene.Net.TestFramework` project. I confirmed that checking the box makes the setting true. So, apparently somehow the output

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2017-02-08 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 I did some more digging, and it seems for NUnit 3.5 they have [moved the output of the tests](https://github.com/nunit/nunit3-vs-adapter/issues/301) to write to the output of the test itself

[GitHub] lucenenet pull request #203: API Work - Stabilization

2017-01-24 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/203 API Work - Stabilization This is a branch of #191 and supersedes that pull request. To build this branch, see the instructions on #191. The plan is to work on the API here to keep

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2017-01-28 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 > Building the sources directly is totally not an option since it would require anyone who wants to try NET Standart version to link the whole source tree into their projects and find a

[GitHub] lucenenet issue #181: Analysis work

2016-08-22 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/181 Actually, all of this is already done in #179. I am intrigued about the EntryIterator bug fix, though. The solution I came up with was to maintain an internal dictionary and return

[GitHub] lucenenet issue #179: Analysis work - Standard and Core namespaces (mostly)

2016-08-22 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/179 I am working on wrapping this up now. Lucene.Net.Analysis.Common is now ported completely except for the Collation namespace and a few odd tests. I have morphed the Lucene 6.1.0

[GitHub] lucenenet issue #179: Analysis work - Standard and Core namespaces (mostly)

2016-08-20 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/179 Update I am nearly completed with Analysis. The only sections yet remaining are `Collation` and `Analysis.Compound`. Nearly all tests have been ported

[GitHub] lucenenet pull request #180: Misc bugs

2016-08-21 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/180 Misc bugs This removes 15 failing tests and in some other cases fixes the test failure message to show the real logic error instead of an exception. You can merge this pull request

[GitHub] lucenenet issue #203: API Work - Stabilization

2017-02-26 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/203 I also apologize for the delayed response. > Is there anything I can help with? Yes, there is. I have been working on cleaning the API up and making it more .NET-l

[GitHub] lucenenet pull request #184: Fixed OfflineSorter Test Failures

2016-09-02 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/184 Fixed OfflineSorter Test Failures This resolves the following failing tests: Core.Util.TestOfflineSorter.TestEmpty Core.Util.TestOfflineSorter.TestIntermediateMerges

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-07 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/185 Ported Core.Util.Fst tests + Core.Util.Packed.TestPackedInts test This includes 3 missing test files from Core.Util, several bug fixes to make the Core.Util.Fst tests pass (all green

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78302841 --- Diff: src/Lucene.Net.Core/AssemblyInfo.cs --- @@ -84,6 +90,6 @@ // (*) Delay Signing is an advanced option - see the Microsoft .NET

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78303194 --- Diff: src/Lucene.Net.TestFramework/Util/fst/FSTTester.cs --- @@ -395,6 +407,24 @@ internal virtual FST DoTest(int prune1, int prune2, bool

[GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...

2016-09-11 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/185#discussion_r78303088 --- Diff: src/Lucene.Net.Tests/core/Util/TestWeakIdentityMap.cs --- @@ -174,12 +188,15 @@ public virtual void TestSimpleHashMap

[GitHub] lucenenet pull request #188: Fixed 64 Failing Tests and Finished Facet Imple...

2016-09-26 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/188 Fixed 64 Failing Tests and Finished Facet Implementation Fixed the 64 failing Facet tests, refactored the public API to be more .NET friendly (changing methods to properties and vice versa

[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-09-29 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/188 > which of the sub-project not ported yet? AFAIK, these are the pieces that are missing that are not currently being worked on, but you should send an email to `

[GitHub] lucenenet issue #174: Ported over Lucene.Net.Spatial

2016-10-05 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/174 @eladmarg There are a couple of snags that could make that idea difficult: 1. Whitespace differences (different number of tabs/spaces, different line break chars, etc) 2

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-05 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/190#discussion_r82028284 --- Diff: Lucene.Net.sln --- @@ -59,14 +60,14 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Lucene.Net.Suggest", &q

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-05 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/190#discussion_r82028685 --- Diff: src/Lucene.Net.Core/Support/DataInputStream.cs --- @@ -0,0 +1,323 @@ +using System; +using System.IO; + +namespace

[GitHub] lucenenet pull request #186: Ported Misc (mostly), Suggest, and Memory

2016-09-19 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/186 Ported Misc (mostly), Suggest, and Memory This pull request contains Lucene.Net.Misc, Lucene.Net.Suggest, and Lucene.Net.Memory. There is also some cleanup of the compiler warnings

[GitHub] lucenenet issue #185: Ported Core.Util.Fst tests + Core.Util.Packed.TestPack...

2016-09-17 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/185 Okay, I added some commits that take care of these issues. I ported the test and worked out how to make the iterator logic work in the WeakIdentityMap. The idea about mimicking

[GitHub] lucenenet pull request #187: Fixed 76 QueryParser Failing Tests

2016-09-22 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/187 Fixed 76 QueryParser Failing Tests This fixes 76 of the 77 failing tests in QueryParser. The remaining one is a matter of completing the test implementation (or removing it entirely

[GitHub] lucenenet issue #181: Analysis work

2016-08-26 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/181 @ChristopherHaws - Hey, I am thinking about taking another shot at porting over Collation. Did you get anything done and/or are you working on it? --- If your project is set up for it, you

[GitHub] lucenenet issue #181: Analysis work

2016-08-27 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/181 I am pulling down your work on Collation so I can work with it. I'll see if I can merge these worlds together - most likely we just need to add some overloads that accept culture to some

[GitHub] lucenenet issue #183: Fix test failures and making SPIClassIterator more per...

2016-08-29 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/183 Thanks. Do note that Analysis.Common also depends on SPIClassIterator, and I had to fix it so it would load classes that don't have a default constructor (which is what

[GitHub] lucenenet issue #181: Analysis work

2016-08-22 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/181 Sure. I am currently working on https://github.com/NightOwl888/lucenenet/commits/analysis-work-2, which I plan to merge into #179 (probably within the next few hours). About the only

[GitHub] lucenenet issue #179: Analysis work - Standard and Core namespaces (mostly)

2016-08-22 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/179 Okay, this is ready for review/merge now. I have synced it up with the master branch already, so there are some commits you have already reviewed here. But you can merge the master branch

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-03 Thread NightOwl888
GitHub user NightOwl888 opened a pull request: https://github.com/apache/lucenenet/pull/190 Ported Analysis.Stempel All 16 tests are passing. I ended up porting over `DataInputStream` and `DataOutputStream` and their corresponding interfaces from Java to save time

[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-10-02 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/188 @synhershko > I say let's first release, then see who uses this. Once we see a lot of usage, we may reconsider the implementation. WDYT? In that case this is ready to

[GitHub] lucenenet issue #186: Ported Misc (mostly), Suggest, and Memory

2016-10-02 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/186 Okay, this one has rebased successfully without any issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] lucenenet issue #189: Fixed 24 Failing Analaysis Tests + Completed CharArray...

2016-10-02 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/189 Yep, definitely a smaller diff. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] lucenenet issue #189: Fixed 24 Failing Analaysis Tests + Completed CharArray...

2016-10-02 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/189 I haven't tried pushing to the repo, but it doesn't look like I have permissions in the GitHub control panel to merge pull requests. It should only take a couple of minutes to fix

[GitHub] lucenenet issue #189: Fixed 24 Failing Analaysis Tests + Completed CharArray...

2016-10-02 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/189 Nope, I have permissions issues: ``` F:\Projects\lucenenet>git push upstream master Enter passphrase for key '/c/Users/Shad/.ssh/id_rsa': ERROR: Sorry, but @apache

[GitHub] lucenenet issue #174: Ported over Lucene.Net.Spatial

2016-11-07 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/174 If there are no objections (meaning nobody else beat me to it), I would like to begin working on this. Observations: - Spatial4n has dependencies on GeoAPI 1.7.2

[GitHub] lucenenet issue #193: Completed Grouping Implementation

2016-11-10 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/193 I have now merged these changes to master. Do note that there is a new commit where the test class override stubs can be reverted (if needed): https://github.com/apache/lucenenet

[GitHub] lucenenet issue #191: [WIP] Migrating Lucene.Net to .NET Core

2016-11-10 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 > >There are 2 different PriorityQueue types in Lucene.Net > Is there a reason for this? Can we stay with one? Yes, there is a reason for that – that i

[GitHub] lucenenet issue #193: Completed Grouping Implementation

2016-11-10 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/193 Oops, looks like the first attempt to push was rejected and I posted the wrong commit before. The new test class override rollback point is: https://github.com/apache/lucenenet/commit

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-11-22 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 Thanks Connie. I am having my first stab at working with this branch, but I am having a few problems getting set up. First of all, I don't have a copy of Visual Studio 2013 developer

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-11-23 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 Here's the file... [restore.zip](https://github.com/apache/lucenenet/files/610313/restore.zip) NOTE: Despite what I said earlier about not wasting effort on .NET 3.5, we

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-11-23 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 > > 1. From command line: dotnet restore > 2. Open Lucene.Net.Portable.sln > 3. Right-click -> Build Solution (Ctrl+Shift+B) > > Do you still ge

[GitHub] lucenenet issue #195: Moving ICU dependent classes into a separate project

2016-11-23 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/195 No offense, but since @conniey has already provided a [working solution to the ICU bitness issue](https://github.com/apache/lucenenet/pull/191#issuecomment-262379449), this seems like a step

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-11-23 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 Prescott, Thanks. I’d appreciate it. It would be better if we could consolidate all development on Visual Studio 2015 Community so others that want to contribute don’t have

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-11-22 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 @Metamorphus Porting Highlighter is the plan, although to my knowledge nobody is currently working on it. It has lagged behind primarily because it depends on the BreakIterator

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-11-22 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 > @NightOwl888 I apologise for the delayed response. Thanks for the ideas with pros and cons. I've been busy at work with another project but will start working on the script today. A

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-11-24 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 > @NightOwl888 seems like the code for Highlighter is too obsolete. It uses classes, which since 4.8 don't exist anymore (e.g. TermEnum) and needs MemoryIndex to be ported to full .NET. Sh

[GitHub] lucenenet issue #174: Ported over Lucene.Net.Spatial

2016-11-25 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/174 Spatial is now complete. The NuGet packages are currently on this MyGet feed: https://www.myget.org/F/spatial4n/api/v2 --- If your project is set up for it, you can reply

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-11-25 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 @conniey FYI - I have completed Lucene.Net.Spatial and it has been added to the master branch. The 2 Spatial4n NuGet dependencies are currently hosted on MyGet here: https

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-11-13 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 > @NightOwl888 @synhershko I am looking through the PR and reducing any unnecessary changes. To make this PR smaller, I was wondering if it would be a good idea to split my changes from NU

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-11-13 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 BTW - your test suite status indicates that you haven't yet merged Lucene.Net.Grouping here. It might be a good idea to ensure there are no issues with it in .NET core (https://github.com

[GitHub] lucenenet issue #191: [WIP] Migrating Lucene.Net to .NET Core

2016-11-02 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 FYI - There are 2 branches that still need to be integrated before this is up to date with master: - https://github.com/NightOwl888/lucenenet/tree/core-tests - https://github.com

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-12-10 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 Update === Build --- I fixed the build issue by adding a NuGet.config file (thanks for the suggestion @conniey). I also pushed a commit to fix the physical directory

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-12-13 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 @conniey I have nearly finished Highlighter on this branch https://github.com/NightOwl888/lucenenet/tree/netcoremigration-highlighter There is still 1 failing test

[GitHub] lucenenet issue #198: Updating minimum Visual Studio version to 2015

2016-12-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/198 Thanks for informing - this was something that slipped in by accident. Ever since I first noticed that VS2012 can't compile these features, I have been trying to keep them out of the code

[GitHub] lucenenet issue #197: Fixing build errors

2016-12-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/197 Not sure why this happened - probably a botched merge of some kind. I'll pull this into master. For future reference, it would work smoother on my end if you just add `fixes #197

[GitHub] lucenenet issue #197: Fixing build errors

2016-12-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/197 See https://github.com/apache/lucenenet/commit/e8735ed9622ab56eaf86bae6394f93f3fb058d30 for an example. If it is something that needs to go in right away (such as this) you could

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-12-05 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 Yes, it is currently at MyGet here: https://www.myget.org/F/spatial4n/api/v2. @synhershko has given me access to push the `Spatial4n.Core` package to NuGet

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-12-04 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 @Metamorphus - Yea, that would be great. I can take care of the other 2 folders and their tests. Just let me know when you have the Highlight tests implemented and where I can grab them

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-12-04 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 > @NightOwl888 Thanks for the detailed explanation. I'll get my first touch to it at weekend, but I anticipate a lot of problems, since I'm only a junior developer (e.g. I'm not even famil

[GitHub] lucenenet issue #200: Adding nunit 3 console package to enable TeamCity to r...

2016-12-18 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/200 > It would be cool to get #191 merged so we can get TeamCity working with the new layout, not sure what is between us and that though. I know there is at least: - Te

[GitHub] lucenenet issue #200: Adding nunit 3 console package to enable TeamCity to r...

2016-12-18 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/200 Hi, does this have anything to do with #194? We should probably revert that change, since it causes a conflict with #191 (which we are actively working on). We really should

[GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core

2016-12-07 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/191 @conniey FYI I have pushed QueryParser.Xml to master. This branch can now be brought up to date by either merging master, or if you prefer you can update one chunk at a time

[GitHub] lucenenet issue #204: Adding missing build configurations for highlighter an...

2017-03-25 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/204 Cool - certainly will be better than sending files one by one :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] lucenenet issue #203: API Work - Stabilization

2017-04-24 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/203 @davhdavh - I have now added the XML documentation to the packages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] lucenenet issue #210: Corrected bug in Lifetime reference count

2017-08-02 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/210 As you can see your commit is here: https://github.com/apache/lucenenet/commits/master What you do with the branch on your GitHub account is up to you. Personally, I usually just

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-15 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 Hi Jens, I'd like to get this merged so I can start working on upgrading to the new `.csproj` format and adding support for the [now released .NET Standard 2.0](https://github.com

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 > Holy crap... I am glad I am not under that umbrella, in an age of continuous delivery and continuous deployment that sounds like poison... o.O... It's both a blessing and a cu

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-10 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 > Actually way back the first time I began to look into Lucene on .NET I did come across a few other attempts on just that, but I guess they died off in favor for this, and to some ext

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-07-11 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 FYI - The CLI tool and docs have been merged to master. https://github.com/apache/lucenenet/tree/cli/src/tools/lucene-cli/docs --- If your project is set up for it, you can reply

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-07-10 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 Thanks. I ended up dividing them into separate documents because it was too easy to scroll by the end of the command you are looking at into the next command, so that was not needed anyway

[GitHub] lucenenet issue #207: API: Added ReferenceManager.AcquireContext()

2017-07-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/207 What about naming? Do you think it would be more intuitive to call it `AcquireReference()` and make the class named `Reference` instead of `ReferenceContext`? Seems like that would be a bit

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-07-08 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 @Shazwazza - Ok, you have explained how to link from one document to another in Markdown. How would you do an anchor within the same document so that it works in DocFx? I went

[GitHub] lucenenet issue #158: Fix for 'Turkish stemmer causes an IndexOutOfRange' (i...

2017-06-28 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/158 Please close this issue now. I have confirmed that this is no longer a problem in Lucene.Net 4.8.0. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] lucenenet pull request #206: API Doc site generator using DocFx script

2017-06-30 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/206#discussion_r125003467 --- Diff: apidocs/docs.ps1 --- @@ -49,10 +49,17 @@ If ($FileExists -eq $False) { if ($Clean -eq 1) { Remove-Item (Join-Path -Path

[GitHub] lucenenet pull request #206: API Doc site generator using DocFx script

2017-06-30 Thread NightOwl888
Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/206#discussion_r12420 --- Diff: apidocs/api/index.md --- @@ -129,6 +128,9 @@ index for all the files contained in a directory. SearchFiles.java prompts

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-06-30 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 I have added some comments inline. I also [asked a question](https://stackoverflow.com/questions/44670354/how-do-you-create-code-references-with-custom-link-text-in-documentation

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-06-29 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 @Shazwazza - Added another minor issue to the above list. Any chance you will be able to answer some of these questions soon? In particular, I would like to know if there is a spec

[GitHub] lucenenet issue #207: API: Added ReferenceManager.AcquireContext()

2017-07-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/207 Looks nice. Although, I tend to favor the "all methods are verbs" and "all properties are nouns or adjectives" methodology. For example, I would expect a method named

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-07-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 Much appreciated - keep up the good work 👍 I am almost to the point where I will start documenting the [new CLI tool](https://github.com/NightOwl888/lucenenet/tree/cli/src/tools

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-07-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 Actually, I was referring to the new "tools" folder under "src" (to keep the docs near the source code the same as they would be by converting the HTML pages from

[GitHub] lucenenet issue #203: API Work - Stabilization

2017-04-26 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/203 @davhdavh > 1. The assemblies are not strong-named in either debug or release build. Per Itamar (the project manager), [Lucene.Net will not be strong-named going forw

[GitHub] lucenenet issue #203: API Work - Stabilization

2017-04-24 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/203 Nope, there is still a lot of broken XML in the documentation comments (see above) that are preventing the process from being complete. It would take a single person the better part of a week

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-05 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 @jeme I got a chance to get a deeper look of this structure, and I found a comment on that blog post that holds the answer to what I think is the part we are struggling

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-07-28 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 > Another thing is that we don't really hide much complexity for the developer but instead take away his freedom to decide when and where indexes etc. should be initialized or at le

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-08-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 During the building of a tool to get the `.html` pages converted, I can break the types of links we have into 3 categories: 1. Code links 2. Repo links 3. Namespace links

[GitHub] lucenenet issue #206: API Doc site generator using DocFx script

2017-08-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/206 BTW - I tried running the code generation after copying and pasting the repo over to a different directory, and I am getting a null reference exception for some reason. ``` Done

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 Jens, thanks for the feedback. While I generally agree with your points, we are unfortunately obligated to work within the confines of the Apache organization, which comes with its

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-08 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 @AndyPook Good point on the `context` parameter. After [taking a closer look](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/4.8.1/lucene/replicator/src/java/org

[GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator

2017-08-08 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/209 > Happy to contribute if that'd help at all. There are definitely [a lot of things](https://github.com/apache/lucenenet/blob/master/CONTRIBUTING.md#other-ways-to-help) you could

  1   2   >