[GitHub] lucenenet issue #175: IndexableField API Consistency Fix
Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/175 Looks good, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] lucenenet issue #175: IndexableField API Consistency Fix
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/175 Ok, I did a search of all of the files in this project for these method names. I only found one other file that referenced any of these fields, and it was in a project that (apparently) doesn't compile. But, I updated the references anyway. If there is something else you are referring to when you say "sub-projects", please help me out by giving me an example. Are there other repositories that depend on this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] lucenenet issue #175: IndexableField API Consistency Fix
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/175 I thought I got everything, but I will take another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] lucenenet issue #175: IndexableField API Consistency Fix
Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/175 Looks good, let's work on getting this in. This PR currently breaks sub-projects, as the API change hasn't been propogated there and to their tests. Can you run the entire solution and make sure this API change is brought all over? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
