[GitHub] lucenenet issue #183: Fix test failures and making SPIClassIterator more per...

2016-09-01 Thread conniey
Github user conniey commented on the issue: https://github.com/apache/lucenenet/pull/183 @synhershko The merge conflicts are resolved now. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] lucenenet issue #183: Fix test failures and making SPIClassIterator more per...

2016-09-01 Thread synhershko
Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/183 Looks good. Pending @NightOwl888 approval before merging this in. Thanks @conniey ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] lucenenet issue #183: Fix test failures and making SPIClassIterator more per...

2016-08-29 Thread conniey
Github user conniey commented on the issue: https://github.com/apache/lucenenet/pull/183 @NightOwl888 I took a look at your branch and merged your `NamedSPILoader` and `SPIClassIterator` changes to avoid you having to do any fix-ups with those classes. --- If your project is set up

[GitHub] lucenenet issue #183: Fix test failures and making SPIClassIterator more per...

2016-08-29 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/183 Thanks. Do note that Analysis.Common also depends on SPIClassIterator, and I had to fix it so it would load classes that don't have a default constructor (which is what the