[GitHub] madlib pull request #229: SVM: Add minibatch as a new solver

2018-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/229 ---

[GitHub] madlib pull request #229: SVM: Add minibatch as a new solver

2018-01-24 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/madlib/pull/229#discussion_r163690557 --- Diff: src/modules/convex/linear_svm_igd.cpp --- @@ -120,6 +124,98 @@ linear_svm_igd_transition::run(AnyType &args) { return state; }

[GitHub] madlib pull request #229: SVM: Add minibatch as a new solver

2018-01-24 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/madlib/pull/229#discussion_r163120094 --- Diff: src/modules/convex/linear_svm_igd.cpp --- @@ -120,6 +124,100 @@ linear_svm_igd_transition::run(AnyType &args) { return state; }

[GitHub] madlib pull request #229: SVM: Add minibatch as a new solver

2018-01-24 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/madlib/pull/229#discussion_r163689232 --- Diff: src/ports/postgres/modules/svm/svm.py_in --- @@ -89,9 +113,9 @@ def _verify_table(source_table, model_table, dependent_varname,

[GitHub] madlib pull request #229: SVM: Add minibatch as a new solver

2018-01-22 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/229#discussion_r163048733 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -56,6 +59,62 @@ IGD::transition(state_type &state, state.task.stepsize * tuple.weight);

[GitHub] madlib pull request #229: SVM: Add minibatch as a new solver

2018-01-22 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/229#discussion_r163022926 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -34,7 +34,10 @@ class IGD { typedef typename Task::model_type model_type; static void

[GitHub] madlib pull request #229: SVM: Add minibatch as a new solver

2018-01-22 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/229#discussion_r163012952 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -34,7 +34,10 @@ class IGD { typedef typename Task::model_type model_type; static vo

[GitHub] madlib pull request #229: SVM: Add minibatch as a new solver

2018-01-19 Thread iyerr3
GitHub user iyerr3 opened a pull request: https://github.com/apache/madlib/pull/229 SVM: Add minibatch as a new solver Additional author: Nikhil Kak This work is based on the original work by Xiaocheng Tang in #75. This PR adds two main features: 1. A