[GitHub] madlib pull request #258: RF: Comment out assert in flaky install check quer...

2018-04-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/madlib/pull/258


---


[GitHub] madlib pull request #258: RF: Comment out assert in flaky install check quer...

2018-04-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/madlib/pull/258


---


[GitHub] madlib pull request #258: RF: Comment out assert in flaky install check quer...

2018-04-06 Thread njayaram2
GitHub user njayaram2 opened a pull request:

https://github.com/apache/madlib/pull/258

RF: Comment out assert in flaky install check query

JIRA: MADLIB-1225

The variable importance computation involves randomization inherently.
So it is hard to reproduce this error consistently. This commit comments
out the assert for now (the failure rate was around 4.3%, when tested over
600 runs).

Closes #258

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/madlib/madlib bugfix/rf/flaky-install-check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/madlib/pull/258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #258


commit f2059aa35de5ab0827cf1d9fa0e39179a6190b49
Author: Nandish Jayaram 
Date:   2018-04-07T00:16:17Z

RF: Comment out assert in flaky install check query

JIRA: MADLIB-1225

The variable importance computation involves randomization inherently.
So it is hard to reproduce this error consistently. This commit comments
out the assert for now (the failure rate was around 4.3%, when tested over
600 runs).

Closes #258




---