[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/289 ---

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-11 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201728550 --- Diff: src/modules/recursive_partitioning/DT_impl.hpp --- @@ -1512,6 +1512,9 @@ DecisionTree::computeVariableImportance( uint64_t m

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201493839 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.sql_in --- @@ -249,9 +250,13 @@ forest_train(training_table_name,

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201489373 --- Diff: src/modules/recursive_partitioning/DT_impl.hpp --- @@ -1512,6 +1512,9 @@ DecisionTree::computeVariableImportance( uint64_

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201501481 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -1291,38 +1300,64 @@ def _create_group_table( schema_ma

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201501719 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -1291,38 +1300,64 @@ def _create_group_table( schema_ma

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201462356 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -616,23 +628,20 @@ def forest_train( _calculate

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201492910 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -1291,38 +1300,64 @@ def _create_group_table( schema_madli

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201490136 --- Diff: src/modules/recursive_partitioning/decision_tree.cpp --- @@ -502,10 +502,13 @@ get_variable_importance::run(AnyType &args){ ColumnVector comb

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201498820 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -1333,42 +1368,69 @@ def _create_group_table( # --

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201493117 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -1333,42 +1368,69 @@ def _create_group_table( # --

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201492311 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -1291,38 +1300,64 @@ def _create_group_table( schema_madli

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-09 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/madlib/pull/289 RF: Add impurity variable importance JIRA: MADLIB-1205 This commit makes the following changes: - Add impurity variable importance for random forests. - Rename current cat_var_im