[GitHub] incubator-madlib pull request #70: Build: Fix version parsing in madpack

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-madlib/pull/70


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib pull request #70: Build: Fix version parsing in madpack

[iyerr3]

Github user iyerr3 commented on a diff in the pull request:

https://github.com/apache/incubator-madlib/pull/70#discussion_r83716925
  
--- Diff: src/madpack/madpack.py ---
@@ -357,7 +356,7 @@ def _get_rev_num(rev):
 @param rev version text
 """
 try:
-num = re.findall('[0-9]', rev)
--- End diff --

The primary bug in `re.findall('[0-9]', rev)` was that a version string 
like `1.3.10` resulted in output `[1, 3, 1, 0]` instead of `[1, 3, 10]`. This 
PR solely aims to fix that. Ideally I would like to use something like 
`distutils.version.LooseVersion` to compare versions, but we also need the 
version parsed in a list and I'm not aware if `LooseVersion` provides that. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib pull request #70: Build: Fix version parsing in madpack

[iyerr3]

GitHub user iyerr3 opened a pull request:

https://github.com/apache/incubator-madlib/pull/70

Build: Fix version parsing in madpack

Primary change is line 359. Other changes are whitespace fixes. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/iyerr3/incubator-madlib 
bugfix/madpack_version_parse

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-madlib/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #70


commit 560e32de98d2303540cb8f0a42aad552eb75db96
Author: Rahul Iyer 
Date:   2016-10-17T18:47:29Z

Build: Fix version parsing in madpack




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---