Re: [PR] [QDP] Refactor: Unify Qubit Validation Logic [mahout]

2026-01-22 Thread via GitHub


rich7420 merged PR #908:
URL: https://github.com/apache/mahout/pull/908


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [QDP] Refactor: Unify Qubit Validation Logic [mahout]

2026-01-22 Thread via GitHub


rich7420 commented on PR #908:
URL: https://github.com/apache/mahout/pull/908#issuecomment-3788028241

   @ryankert01 , @viiccwen thanks for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] [QDP] Refactor: Unify Qubit Validation Logic [mahout]

2026-01-21 Thread via GitHub


rich7420 opened a new pull request, #908:
URL: https://github.com/apache/mahout/pull/908

   ### Purpose of PR
   
   This PR refactors the qubit validation logic across all encoders to 
eliminate code duplication and improve maintainability. It introduces a shared 
constant `MAX_QUBITS` and a unified validation function 
`validate_qubit_count()` that is used consistently across the codebase.
   
   ### Related Issues or PRs
   
   
   
   
   ### Changes Made
   
   - [ ] Bug fix
   - [ ] New feature
   - [x] Refactoring
   - [ ] Documentation
   - [ ] Test
   - [ ] CI/CD pipeline
   - [ ] Other
   
   ### Breaking Changes
   
   - [ ] Yes
   - [x] No
   
   ### Checklist
   
   
   
   - [x] Added or updated unit tests for all changes
   - [ ] Added or updated documentation for all changes
   - [x] Successfully built and ran all unit tests or manual tests locally
   - [ ] PR title follows "MAHOUT-XXX: Brief Description" format (if related to 
an issue)
   - [ ] Code follows ASF guidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]