Re: [PR] [QDP] Upgrade tch to 0.22 [mahout]
guan404ming commented on PR #872: URL: https://github.com/apache/mahout/pull/872#issuecomment-3767322208 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [QDP] Upgrade tch to 0.22 [mahout]
guan404ming merged PR #872: URL: https://github.com/apache/mahout/pull/872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [QDP] Upgrade tch to 0.22 [mahout]
guan404ming commented on PR #872: URL: https://github.com/apache/mahout/pull/872#issuecomment-3767288475 The file I modified is for ci env. If we are in local env, we need to `export LIBTORCH_USE_PYTORCH=1 to .bashrc/.zshrc` to make the clippy use local torch instead of libtorch which require extra installation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [QDP] Upgrade tch to 0.22 [mahout]
400Ping commented on PR #872: URL: https://github.com/apache/mahout/pull/872#issuecomment-3767314201 > The file I modified is for ci env. If we are in local env, we need to `export LIBTORCH_USE_PYTORCH=1 to .bashrc/.zshrc` to make the `clippy` use local `torch` instead of `libtorch`, which require extra installation. Oh yeah right I remember this now when I was adding libtorch workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [QDP] Upgrade tch to 0.22 [mahout]
guan404ming commented on PR #872: URL: https://github.com/apache/mahout/pull/872#issuecomment-3767299522 I have added the config instruction in `contributing.md` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [QDP] Upgrade tch to 0.22 [mahout]
ryankert01 commented on code in PR #872:
URL: https://github.com/apache/mahout/pull/872#discussion_r2703888396
##
.github/workflows/pre-commit.yml:
##
@@ -41,16 +41,9 @@ jobs:
run: pip install uv
- name: Install dependencies
-run: uv sync --group dev
-
- - name: Install libtorch (CPU)
-run: |
- set -euo pipefail
- libtorch_version="2.2.0"
-
libtorch_zip="libtorch-cxx11-abi-shared-with-deps-${libtorch_version}%2Bcpu.zip"
- curl -L -o libtorch.zip
"https://download.pytorch.org/libtorch/cpu/${libtorch_zip}";
- unzip -q libtorch.zip
- echo "LIBTORCH=${GITHUB_WORKSPACE}/libtorch" >> "$GITHUB_ENV"
+run: uv sync --extra qdp --group dev
- name: Run pre-commit hooks
run: uv run pre-commit run --all-files
+env:
+ LIBTORCH_USE_PYTORCH: 1
Review Comment:
You guys are using lib torch or not? Or how to remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [QDP] Upgrade tch to 0.22 [mahout]
ryankert01 commented on code in PR #872:
URL: https://github.com/apache/mahout/pull/872#discussion_r2703888396
##
.github/workflows/pre-commit.yml:
##
@@ -41,16 +41,9 @@ jobs:
run: pip install uv
- name: Install dependencies
-run: uv sync --group dev
-
- - name: Install libtorch (CPU)
-run: |
- set -euo pipefail
- libtorch_version="2.2.0"
-
libtorch_zip="libtorch-cxx11-abi-shared-with-deps-${libtorch_version}%2Bcpu.zip"
- curl -L -o libtorch.zip
"https://download.pytorch.org/libtorch/cpu/${libtorch_zip}";
- unzip -q libtorch.zip
- echo "LIBTORCH=${GITHUB_WORKSPACE}/libtorch" >> "$GITHUB_ENV"
+run: uv sync --extra qdp --group dev
- name: Run pre-commit hooks
run: uv run pre-commit run --all-files
+env:
+ LIBTORCH_USE_PYTORCH: 1
Review Comment:
You guys are using lib torch or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [QDP] Upgrade tch to 0.22 [mahout]
400Ping commented on code in PR #872:
URL: https://github.com/apache/mahout/pull/872#discussion_r2703883912
##
.github/workflows/pre-commit.yml:
##
@@ -41,16 +41,9 @@ jobs:
run: pip install uv
- name: Install dependencies
-run: uv sync --group dev
-
- - name: Install libtorch (CPU)
-run: |
- set -euo pipefail
- libtorch_version="2.2.0"
-
libtorch_zip="libtorch-cxx11-abi-shared-with-deps-${libtorch_version}%2Bcpu.zip"
- curl -L -o libtorch.zip
"https://download.pytorch.org/libtorch/cpu/${libtorch_zip}";
- unzip -q libtorch.zip
- echo "LIBTORCH=${GITHUB_WORKSPACE}/libtorch" >> "$GITHUB_ENV"
+run: uv sync --extra qdp --group dev
- name: Run pre-commit hooks
run: uv run pre-commit run --all-files
+env:
+ LIBTORCH_USE_PYTORCH: 1
Review Comment:
This is unnecessary since we are removing libtorch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [QDP] Upgrade tch to 0.22 [mahout]
guan404ming commented on PR #872: URL: https://github.com/apache/mahout/pull/872#issuecomment-3767163663 @400Ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
