Re: Pattern for commit comment

[Daniel Takabayashi]

+1

Em seg, 26 de nov de 2018 às 13:43, Luciano Resende 
escreveu:

> Just a minor suggestion, to follow what other projects have been using,
> have the jira between brackets ?
>
> [MARVIN-XX] xxx
>
>
> On Fri, Nov 23, 2018 at 19:05 William Colen 
> wrote:
>
> > What do you think of defining a pattern for commit comment? There are
> > guidelines for that, but basically you could:
> > - start with the issue so it looks better in reports
> > - keep the first line message small so it takes just one line in reports
> >
> > Something like this:
> > `MARVIN-00: This is a commit message`
> >
> > What do you think?
> >
> > William
> >
> --
> Sent from my Mobile device
>

Re: Pattern for commit comment

[Zhang Yifei]

+1

Em seg, 26 de nov de 2018 às 13:49, Daniel Takabayashi <
daniel.takabaya...@gmail.com> escreveu:

> +1
>
> Sent from my iPhone
>
> > On Nov 26, 2018, at 6:30 AM, Rafael Novello 
> wrote:
> >
> > +1 for both suggestions!
> >
> > I'll use this patterns and we could add it on "how to contribute" doc!
> >
> > Atenciosamente,
> > Rafael J. R. Novello
> >
> > Skype: rafael.novello
> > Blog: http://rafanovello.blogspot.com.br/
> >
> >
> > Em sex, 23 de nov de 2018 às 16:05, William Colen <
> william.co...@gmail.com>
> > escreveu:
> >
> >> What do you think of defining a pattern for commit comment? There are
> >> guidelines for that, but basically you could:
> >> - start with the issue so it looks better in reports
> >> - keep the first line message small so it takes just one line in reports
> >>
> >> Something like this:
> >> `MARVIN-00: This is a commit message`
> >>
> >> What do you think?
> >>
> >> William
> >>
>


-- 
--
Zhang Yifei