[GitHub] maven-surefire pull request #123: Add test for setting environment variables...

2016-10-03 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/maven-surefire/pull/123 Add test for setting environment variables from surefire configuratio… …n for JUnit 5 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] maven-surefire issue #123: Add test for setting environment variables from s...

2016-10-03 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/123 @Tibor17 finally found some time to work on more ITs :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-surefire pull request #125: Consistently rename JUnit 4.x integration ...

2016-10-03 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/maven-surefire/pull/125 Consistently rename JUnit 4.x integration tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/britter/maven-surefire

[GitHub] maven-surefire pull request #124: Fix formatting, convert tabs to spaces

2016-10-03 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/maven-surefire/pull/124 Fix formatting, convert tabs to spaces Just some minor cosmetic changes... You can merge this pull request into a Git repository by running: $ git pull

[SUREFIRE] JUnit 5 support - how to move things forward?

2016-10-03 Thread Benedikt Ritter
Hi, now that we have a separate branch for the JUnit 5 support in the surefire repo, I'm asking myself how to much things forward. I've added some additional IT implementations in my GitHub fork, but they all fail because the 5.0.0-M2 release of junit-surefire-provider does not implement the

[GitHub] maven-surefire pull request #125: Consistently rename JUnit 4.x integration ...

2016-10-03 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/125#discussion_r81666066 --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit47ConcurrencyIT.java --- @@ -32,14 +32,14 @@ * *

Re: [SUREFIRE] JUnit 5 support - how to move things forward?

2016-10-03 Thread Tibor Digana
+1 to adopt JUnit 5 provider to Maven Surefire git branch. You would have to extend AbstractSurefireMojo.java with JUnit 5 provider in classpath builder. Do we have to keep using other license? Can we ask the JUnit team to continuously migrate stable changes to Surefire? On Mon, Oct 3, 2016 at

Re: [SUREFIRE] JUnit 5 support - how to move things forward?

2016-10-03 Thread Tibor Digana
Can you simplify and speed up writing integration tests in the way that you would parameterize the existing JUnit 4 testing by adding Maven profiles (one default profile and junit5 profile) having another dependencies and @RunWith(Parameterized.class)? This would be cool because we can have

Re: Would Commons Lang on Java 8 be a problem for the Apache Maven project?

2016-10-03 Thread Benedikt Ritter
Hi, sorry for the late reply... :-) Stephen Connolly schrieb am Mo., 26. Sep. 2016 um 12:03 Uhr: > Well another question is how much longer will we support Java 7 anyway... > what we have said in the past is the next release line after JDK9 is > released will