[GitHub] maven-surefire pull request #136: [SUREFIRE-1295] Attribute JVM crashes to t...

2016-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire issue #136: [SUREFIRE-1295] Attribute JVM crashes to tests

2016-11-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/136 @michaeltandy I will use your test but meanwhile I would like to avoid channelId used in ForckClient because channelId is obsolete and ForkClient is used per for/thread and therefore

Re: Restore default escaping in maven-resources-plugin?

2016-11-30 Thread Christian Schulte
Am 11/29/16 um 20:01 schrieb Robert Scholte: > How about no escape character? This also implies that escaping is off by > default. +1 That's what was the default prior 3.0.0. Just revert that and be done with it. - To

[GitHub] maven-surefire issue #136: [SUREFIRE-1295] Attribute JVM crashes to tests

2016-11-30 Thread michaeltandy
Github user michaeltandy commented on the issue: https://github.com/apache/maven-surefire/pull/136 Back when I wrote my patch I didn't realise channelId was obsolete. If you want to get rid of it that's fine with me - I'm certainly not using it. --- If your project is set up for it,

[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...

2016-11-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter I think no user would like to specify `` in plugin in POM and he would not specify whether junit4 or junit5 as a duplicate to provider dependency. Basically all we need to

[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...

2016-11-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter It is not the right way to detect the presents of the JUnit annotations in classpath because the test classes may initialize static context yet in Maven process like we do

[GitHub] maven-surefire issue #134: [SUREFIRE-1308] Move Surefire1179IT to jiras pack...

2016-11-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/134 @britter Done. Thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven-surefire issue #132: SUREFIRE-1306: JUnit4RerunFailingTestsIT does not...

2016-11-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/132 @britter I have fixed the issue but it is JUnit 4.7 issue. This is useless `.addGoal( "-Dprovider=surefire-junit4" )` and `.setJUnitVersion( "4.7" )` ditto because it's always the

[GitHub] maven-surefire issue #132: SUREFIRE-1306: JUnit4RerunFailingTestsIT does not...

2016-11-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/132 @britter Done. Thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...

2016-11-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter Yes, Let's use profiles for our testing purposes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your