Re: Found Issues - Release Apache Maven Version 3.6.2

2019-09-02 Thread Alexander Bubenchikov
Sorry for late reply, Tibor. I'll look into it and create a new thread/PR regarding this. Despite it will not solve our problems with maintaining compatibility now (there are plenty of users who need old maven versions), it will greatly helps in future. On Thu, Aug 29, 2019 at 9:51 PM Tibor

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Tibor Digana
Hi Alexander, Would it solve your problem if we uncover the method [1] and develop a builder for the chain of methods [2]? To uncover [2] means to make the Plexus Container API accessible within the builder. Perhaps more has to be done but that's up to the future collaborative work on GitHub.

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Tibor Digana
We are draming of Maven 4 and Maven 5 and features in it, and we have legacy code + patch over a patch. We are using Guice with a nice Guice API and we are using components.xml like it was in the old Spring. Would it be a good time to change some code in favor of modern style? Nevertheless this

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Alexander Bubenchikov
Hi Stuart E.g. https://github.com/JetBrains/intellij-community/blob/master/plugins/maven/maven3-server-impl/src/org/jetbrains/idea/maven/server/Maven3XServerEmbedder.java customizeComponents method Originally idea use own components defined in META-INF/plexus/components.xml with hints "ide", then

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Stuart McCulloch
How are you replacing them currently? The typical way is to use the extensions mechanism: https://maven.apache.org/docs/3.3.1/release-notes.html#Core_Extensions Components contributed via an extension have a higher priority over the original component in core (assuming that they have the same

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Enrico Olivelli
Il gio 29 ago 2019, 12:46 Alexander Bubenchikov < alexander.bubenchi...@jetbrains.com> ha scritto: > Hi Enrico, my name is Alex, I've joined to Jetbrains this year and > responsible for maven integration and Intellij idea. > Nice to meet you Alex I am sorry I am not an expert of this part of

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Tibor Digana
Having interface in a singleton is a kind of silly design because these are two abstractions which go one against the other. The CDI has an injection Provider and you caniterate over beans of certain bean type and select according @Name then. I think this mechanism can be used. On Thu, Aug 29,

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-29 Thread Alexander Bubenchikov
Hi Enrico, my name is Alex, I've joined to Jetbrains this year and responsible for maven integration and Intellij idea. he issue happen because we replace some components in maven (ModelInterpolator in this case) to our own implementation which have injected PathTranslator and UrlNormalizer I've

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-28 Thread Enrico Olivelli
It may be due to any change regarding jsr 330 like https://issues.apache.org/jira/plugins/servlet/mobile#issue/MNG-6686 I think it is an issue for Idea and not for us. It would be good to have some developer from Jetbrains on this list Enrico Il mer 28 ago 2019, 22:23 Tibor Digana ha

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-28 Thread Tibor Digana
I do not have NPE in the log. Guice is certainly not CDI. Moving Guice to CDI must be painful. One reason why PathTranslator could not be found is that there are several bean instances of the same interface. Second problem might go with the Guice/CDI. See this inheritance: @Named @Singleton

Re: Found Issues - Release Apache Maven Version 3.6.2

2019-08-28 Thread Filipe Sousa
Hi, Not sure if it’s the same bug I commented in https://issues.apache.org/jira/browse/MNG-6638?focusedCommentId=16852351=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16852351 I reported to Jetbrains https://youtrack.jetbrains.com/issue/IDEA-215315

Found Issues - Release Apache Maven Version 3.6.2

2019-08-28 Thread Tibor Digana
I used Maven 3.6.2 in the IntelliJ IDEA 2019.2.1 and I found these errors in the log file: ~/.IntelliJIdea2019.2/system/log/idea.log 2019-08-28 21:31:32,072 [255937677] ERROR - #org.jetbrains.idea.maven - com.google.inject.CreationException: Unable to create injector, see the following