Re: [PR] Get rid of various warnings [maven-hocon-extension]
ppalaga commented on PR #6: URL: https://github.com/apache/maven-hocon-extension/pull/6#issuecomment-2364081024 > > Could we perhaps enable GitHub issues for this project? > > Probably shouldn't. Most Apache prijects and definitely Maven have been using the Apache Jira instance for a liong time. It is true that Maven uses Jira and I'd personally be happier if it wasn't the case. GH issues are faster and much easier to use. I think esp. for subprojects like this one, it is much better to have the issues closer to the code to allow more focused discussions and fine-grained notifications. [mvnd](https://github.com/apache/maven-mvnd/issues) might serve as a positive example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [PR] Get rid of various warnings [maven-hocon-extension]
cstamas merged PR #6: URL: https://github.com/apache/maven-hocon-extension/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [PR] Get rid of various warnings [maven-hocon-extension]
cstamas commented on PR #6: URL: https://github.com/apache/maven-hocon-extension/pull/6#issuecomment-2363558725 @jorsol yup, just realized myself the discrepancy here: https://gist.github.com/cstamas/c81a66a3f11d90fa9332b893c9ab26b6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [PR] Get rid of various warnings [maven-hocon-extension]
jorsol commented on PR #6: URL: https://github.com/apache/maven-hocon-extension/pull/6#issuecomment-2363516721 > Is even more strange, as 4.0.0-beta-4 does contain up-to-date wrapper plugin version: https://github.com/apache/maven/blob/maven-4.0.0-beta-4/maven-core/src/main/java/org/apache/maven/internal/impl/DefaultLifecycleRegistry.java#L468 > > So why it did not use "only-script" type that is default in 3.2.0? 🤔 3.2.0 is not up-to-date, latest version is [3.3.2](https://github.com/apache/maven-wrapper/releases/tag/maven-wrapper-3.3.2), the change to `only-script` type by default was added in 3.3.0: https://github.com/apache/maven-wrapper/releases/tag/maven-wrapper-3.3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [PR] Get rid of various warnings [maven-hocon-extension]
elharo commented on PR #6: URL: https://github.com/apache/maven-hocon-extension/pull/6#issuecomment-2363514008 > Could we perhaps enable GitHub issues for this project? Probably shouldn't. Most Apache prijects and definitely Maven have been using the Apache Jira instance for a liong time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [PR] Get rid of various warnings [maven-hocon-extension]
cstamas commented on PR #6: URL: https://github.com/apache/maven-hocon-extension/pull/6#issuecomment-2363504651 Is even more strange, as 4.0.0-beta-4 does contain up-to-date wrapper plugin version: https://github.com/apache/maven/blob/maven-4.0.0-beta-4/maven-core/src/main/java/org/apache/maven/internal/impl/DefaultLifecycleRegistry.java#L468 So why it did not use "only-script" type? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [PR] Get rid of various warnings [maven-hocon-extension]
cstamas commented on PR #6: URL: https://github.com/apache/maven-hocon-extension/pull/6#issuecomment-2363498704 Just realized: something was strange (re wrapper, not this project). I used Maven 4.0.0-beta-4 as it is enforced to build this project with that version. Then I did `mvn wrapper:wrapper` that resulting in this PR (+ pom change). BUT this PR is _wrong_: the default type is script-only, the wrapper.jar should NOT be here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [PR] Get rid of various warnings [maven-hocon-extension]
ppalaga commented on PR #6: URL: https://github.com/apache/maven-hocon-extension/pull/6#issuecomment-2363496208 Could we perhaps enable GitHub issues for this project? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
