Re: [SUREFIRE] Branch for JUnit 5 integration?

2016-09-18 Thread Benedikt Ritter
Hello,

the branch with the first JUnit 5 IT is ready for reintegration. My
proposal is to create a separate branch for working on JUnit 5 so that we
can merge it to master only when all work on JUnit 5 support is done.

Regards,
Benedikt

Tibor Digana  schrieb am Mo., 12. Sep. 2016 um
01:13 Uhr:

> ok, go on with the branch but then please create CI job in
> https://builds.apache.org/job/maven-surefire/.
> We will nicely see how the branch is still in green.
> I want to be brief. I understand that this work takes private time, I was
> idle for cca 5 months in Surefire and recovered recently. Many colleagues
> in Maven are idle for years and only send some emails but these emails move
> us ahead which is positive as well.
>
> On Sat, Sep 10, 2016 at 2:49 PM, Benedikt Ritter [via Maven] <
> ml-node+s40175n5880358...@n5.nabble.com> wrote:
>
> > Hi,
> >
> > I'm currently a bit stuck with the JUnit 5 integration, because I don't
> > really know where it should be going. At first I thought we should just
> > merge the Integration tests I'm about to write directly to master. But
> > maybe that's not the best idea. But I don't want to implement the whole
> > thing in my fork as well since this will lead to a unmanagable huge
> change
> > set when it will be reintegrated. So my proposal is to create a separate
> > branch in the maven-surefire repo I can open PRs against. This way I can
> > iteratively add more stuff in small chucks but is does not land directly
> > on
> > master.
> >
> > WDYT?
> >
> > Regards,
> > Benedikt
> >
> >
> > --
> > If you reply to this email, your message will be added to the discussion
> > below:
> > http://maven.40175.n5.nabble.com/SUREFIRE-Branch-for-JUnit-
> > 5-integration-tp5880358.html
> > To start a new topic under Maven Developers, email
> > ml-node+s40175n142166...@n5.nabble.com
> > To unsubscribe from Maven Developers, click here
> > <
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==
> >
> > .
> > NAML
> > <
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> >
> >
>
>
>
>
> --
> View this message in context:
> http://maven.40175.n5.nabble.com/Re-SUREFIRE-Branch-for-JUnit-5-integration-tp5880473.html
> Sent from the Maven Developers mailing list archive at Nabble.com.


Re: [SUREFIRE] Branch for JUnit 5 integration?

2016-09-11 Thread Tibor Digana
ok, go on with the branch but then please create CI job in
https://builds.apache.org/job/maven-surefire/.
We will nicely see how the branch is still in green.
I want to be brief. I understand that this work takes private time, I was
idle for cca 5 months in Surefire and recovered recently. Many colleagues
in Maven are idle for years and only send some emails but these emails move
us ahead which is positive as well.

On Sat, Sep 10, 2016 at 2:49 PM, Benedikt Ritter [via Maven] <
ml-node+s40175n5880358...@n5.nabble.com> wrote:

> Hi,
>
> I'm currently a bit stuck with the JUnit 5 integration, because I don't
> really know where it should be going. At first I thought we should just
> merge the Integration tests I'm about to write directly to master. But
> maybe that's not the best idea. But I don't want to implement the whole
> thing in my fork as well since this will lead to a unmanagable huge change
> set when it will be reintegrated. So my proposal is to create a separate
> branch in the maven-surefire repo I can open PRs against. This way I can
> iteratively add more stuff in small chucks but is does not land directly
> on
> master.
>
> WDYT?
>
> Regards,
> Benedikt
>
>
> --
> If you reply to this email, your message will be added to the discussion
> below:
> http://maven.40175.n5.nabble.com/SUREFIRE-Branch-for-JUnit-
> 5-integration-tp5880358.html
> To start a new topic under Maven Developers, email
> ml-node+s40175n142166...@n5.nabble.com
> To unsubscribe from Maven Developers, click here
> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==>
> .
> NAML
> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>




--
View this message in context: 
http://maven.40175.n5.nabble.com/Re-SUREFIRE-Branch-for-JUnit-5-integration-tp5880473.html
Sent from the Maven Developers mailing list archive at Nabble.com.