Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-10 Thread Mark Raynsford
> On 2018-11-10T16:47:59 +0100 > Hervé BOUTEMY wrote: > > > ok, I investigated more in details and added a little trick in [1]: > > child.site.url.inherit.append.path is inherited independantly from > > id/name/url > > > > this will manage your edge case, which I can understand is expected >

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-10 Thread Mark Raynsford
On 2018-11-10T16:47:59 +0100 Hervé BOUTEMY wrote: > ok, I investigated more in details and added a little trick in [1]: > child.site.url.inherit.append.path is inherited independantly from id/name/url > > this will manage your edge case, which I can understand is expected > > do you think it

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-10 Thread Hervé BOUTEMY
ok, I investigated more in details and added a little trick in [1]: child.site.url.inherit.append.path is inherited independantly from id/name/url this will manage your edge case, which I can understand is expected do you think it is ok? Regards, Hervé [1]

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-06 Thread Hervé BOUTEMY
Le mardi 6 novembre 2018, 10:35:25 CET Mark Raynsford a écrit : > 'Ello. > > On 2018-11-06T00:03:53 +0100 > > Hervé BOUTEMY wrote: > > Hi Mark, > > > > even if this is somewhat a corner case (while overriding everything in b, > > you can override the attribute also), it is strange... > > I'm

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-06 Thread Mark Raynsford
'Ello. On 2018-11-06T00:03:53 +0100 Hervé BOUTEMY wrote: > Hi Mark, > > even if this is somewhat a corner case (while overriding everything in b, you > can override the attribute also), it is strange... I'm not sure it's a corner case, exactly. It reflects the real-life situation I'm in:

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-05 Thread Hervé BOUTEMY
Hi Mark, even if this is somewhat a corner case (while overriding everything in b, you can override the attribute also), it is strange... The more immediate check is to run "mvn help:effective-pom" on b to check that child.site.url.inherit.append.path is configured: I still don't understand

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-05 Thread Mark Raynsford
On 2018-11-04T15:05:19 + Mark Raynsford wrote: > On 2018-11-04T15:34:11 +0100 > Hervé BOUTEMY wrote: > > > you can build https://github.com/apache/maven/tree/MNG-6059 with quick > > build > > instruction at the end of README > > > > Thanks. I've built

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-04 Thread Mark Raynsford
On 2018-11-04T15:34:11 +0100 Hervé BOUTEMY wrote: > you can build https://github.com/apache/maven/tree/MNG-6059 with quick build > instruction at the end of README > Thanks. I've built 523db580468bc2b9d8420470bb24f5f688220701 and it seems to be working for all but the

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-04 Thread Hervé BOUTEMY
you can build https://github.com/apache/maven/tree/MNG-6059 with quick build instruction at the end of README Regards, Hervé Le dimanche 4 novembre 2018, 13:48:51 CET Mark Raynsford a écrit : > On 2018-11-04T13:34:39 +0100 > > Hervé BOUTEMY wrote: > > Hi Mark, > > > > Seems you found one

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-04 Thread Mark Raynsford
On 2018-11-04T13:34:39 +0100 Hervé BOUTEMY wrote: > Hi Mark, > > Seems you found one more thing that I forgot when merging MNG-6059: > inheritance of these child.inherit.append.path configurations... > > I created MNG-6505 [1] and added the fix to MNG-6059 branch. > > Can you check that it

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-04 Thread Hervé BOUTEMY
Hi Mark, Seems you found one more thing that I forgot when merging MNG-6059: inheritance of these child.inherit.append.path configurations... I created MNG-6505 [1] and added the fix to MNG-6059 branch. Can you check that it works as you expect? (notice: with the new