ok no worries, it was a nice to have if it wasn't yet on master.
On Sat, May 23, 2020 at 1:04 PM Karl Heinz Marbaise
wrote:
>
> HI,
>
> On 23.05.20 12:51, Arnaud Héritier wrote:
> > LGTM
> > Rebasing the code could be great if not too difficult
>
> Unfortunately the code is already on master
HI,
On 23.05.20 12:51, Arnaud Héritier wrote:
LGTM
Rebasing the code could be great if not too difficult
Unfortunately the code is already on master with all commits
Kind regards
Karl Heinz Marbaise
On Sat, May 23, 2020 at 12:32 PM Enrico Olivelli
wrote:
Approved on github
+1
I
LGTM
Rebasing the code could be great if not too difficult
On Sat, May 23, 2020 at 12:32 PM Enrico Olivelli
wrote:
> Approved on github
>
> +1
> I have run thru the diff.
> It looks very well
>
> Longing for testing it on a real project
>
> The fact that you won't have to commit mave wrapper
Approved on github
+1
I have run thru the diff.
It looks very well
Longing for testing it on a real project
The fact that you won't have to commit mave wrapper jar to local sources is
great
Enrico
Il Ven 22 Mag 2020, 22:56 Manfred Moser ha
scritto:
> Awesome! +1
>
> Robert Scholte wrote on
Awesome! +1
Robert Scholte wrote on 2020-05-22 13:36 (GMT -07:00):
> I've reached the point where apache-maven-wrapper is ready to be merged into
> master.
> The code contains all original commits and a few from me to get them step by
> step into core.
>
> Related tickets:
>
