Re: second apache-maven-wrapper
ok no worries, it was a nice to have if it wasn't yet on master. On Sat, May 23, 2020 at 1:04 PM Karl Heinz Marbaise wrote: > > HI, > > On 23.05.20 12:51, Arnaud Héritier wrote: > > LGTM > > Rebasing the code could be great if not too difficult > > Unfortunately the code is already on master with all commits > > Kind regards > Karl Heinz Marbaise > > > > > On Sat, May 23, 2020 at 12:32 PM Enrico Olivelli > > wrote: > > > >> Approved on github > >> > >> +1 > >> I have run thru the diff. > >> It looks very well > >> > >> Longing for testing it on a real project > >> > >> The fact that you won't have to commit mave wrapper jar to local > sources is > >> great > >> > >> > >> Enrico > >> > >> Il Ven 22 Mag 2020, 22:56 Manfred Moser ha > >> scritto: > >> > >>> Awesome! +1 > >>> > >>> Robert Scholte wrote on 2020-05-22 13:36 (GMT -07:00): > >>> > I've reached the point where apache-maven-wrapper is ready to be > merged > >>> into > master. > The code contains all original commits and a few from me to get them > >>> step by > step into core. > > Related tickets: > https://issues.apache.org/jira/browse/MNG-5937 > > https://issues.apache.org/jira/browse/MNG-6914 > > > https://github.com/apache/maven/pull/349 > > https://github.com/apache/maven-integration-testing/pull/62 > > > thanks, > Robert > -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier
Re: second apache-maven-wrapper
HI, On 23.05.20 12:51, Arnaud Héritier wrote: LGTM Rebasing the code could be great if not too difficult Unfortunately the code is already on master with all commits Kind regards Karl Heinz Marbaise On Sat, May 23, 2020 at 12:32 PM Enrico Olivelli wrote: Approved on github +1 I have run thru the diff. It looks very well Longing for testing it on a real project The fact that you won't have to commit mave wrapper jar to local sources is great Enrico Il Ven 22 Mag 2020, 22:56 Manfred Moser ha scritto: Awesome! +1 Robert Scholte wrote on 2020-05-22 13:36 (GMT -07:00): I've reached the point where apache-maven-wrapper is ready to be merged into master. The code contains all original commits and a few from me to get them step by step into core. Related tickets: https://issues.apache.org/jira/browse/MNG-5937 https://issues.apache.org/jira/browse/MNG-6914 https://github.com/apache/maven/pull/349 https://github.com/apache/maven-integration-testing/pull/62 thanks, Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: second apache-maven-wrapper
LGTM Rebasing the code could be great if not too difficult On Sat, May 23, 2020 at 12:32 PM Enrico Olivelli wrote: > Approved on github > > +1 > I have run thru the diff. > It looks very well > > Longing for testing it on a real project > > The fact that you won't have to commit mave wrapper jar to local sources is > great > > > Enrico > > Il Ven 22 Mag 2020, 22:56 Manfred Moser ha > scritto: > > > Awesome! +1 > > > > Robert Scholte wrote on 2020-05-22 13:36 (GMT -07:00): > > > > > I've reached the point where apache-maven-wrapper is ready to be merged > > into > > > master. > > > The code contains all original commits and a few from me to get them > > step by > > > step into core. > > > > > > Related tickets: > > > https://issues.apache.org/jira/browse/MNG-5937 > > > > > > https://issues.apache.org/jira/browse/MNG-6914 > > > > > > > > > https://github.com/apache/maven/pull/349 > > > > > > https://github.com/apache/maven-integration-testing/pull/62 > > > > > > > > > thanks, > > > Robert > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier
Re: second apache-maven-wrapper
Approved on github +1 I have run thru the diff. It looks very well Longing for testing it on a real project The fact that you won't have to commit mave wrapper jar to local sources is great Enrico Il Ven 22 Mag 2020, 22:56 Manfred Moser ha scritto: > Awesome! +1 > > Robert Scholte wrote on 2020-05-22 13:36 (GMT -07:00): > > > I've reached the point where apache-maven-wrapper is ready to be merged > into > > master. > > The code contains all original commits and a few from me to get them > step by > > step into core. > > > > Related tickets: > > https://issues.apache.org/jira/browse/MNG-5937 > > > > https://issues.apache.org/jira/browse/MNG-6914 > > > > > > https://github.com/apache/maven/pull/349 > > > > https://github.com/apache/maven-integration-testing/pull/62 > > > > > > thanks, > > Robert > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: second apache-maven-wrapper
Awesome! +1 Robert Scholte wrote on 2020-05-22 13:36 (GMT -07:00): > I've reached the point where apache-maven-wrapper is ready to be merged into > master. > The code contains all original commits and a few from me to get them step by > step into core. > > Related tickets: > https://issues.apache.org/jira/browse/MNG-5937 > > https://issues.apache.org/jira/browse/MNG-6914 > > > https://github.com/apache/maven/pull/349 > > https://github.com/apache/maven-integration-testing/pull/62 > > > thanks, > Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
