Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
Closing this PR since reviews are in the review board.
---
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
@tilt, here you go: https://reviews.apache.org/r/66621/.
---
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
@tilt, yes, large diff because I refactored a bit and added as many tests
as there are for HS256. :)
---
Github user tillt commented on the issue:
https://github.com/apache/mesos/pull/281
@clems4ever and missed that as well :D - it was hidden due to its size
(large diff).
---
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
@tilt, what do you mean? There are tests in the commit already.
---
Github user tillt commented on the issue:
https://github.com/apache/mesos/pull/281
@clems4ever can we have tests as well? :)
---
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
@tillt , no pb, I will create a review in the review board now. Thanks.
---
Github user tillt commented on the issue:
https://github.com/apache/mesos/pull/281
@clems4ever I totally missed your second PR - sorry for that. Merged it now.
---
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
Hello @tillt , thank you for having a look. Don't you need to merge the
following PR to make me a contributor:
https://github.com/apache/mesos/pull/282/commits?
---
Github user tillt commented on the issue:
https://github.com/apache/mesos/pull/281
@clems4ever this looks really good - let's get it into a committable state.
I have added you to Apache Mesos as a contributor and assigned me as a shepherd
to your improvement.
---
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
Since this change is not really trivial, I will go through the contributing
process. I'm currently creating my accounts.
---
11 matches
Mail list logo
