Re: Deprecating `--disable-zlib` in libprocess

2017-08-08 Thread Jie Yu
+1 on removing this flag.

On Tue, Aug 8, 2017 at 11:32 AM, Benjamin Mahler  wrote:

> Sorry, I think this was me, feel free to remove it from libprocess now that
> it's required.
>
> On Tue, Aug 8, 2017 at 10:57 AM, Chun-Hung Hsiao 
> wrote:
>
> > Hi all,
> >
> > In libprocess, we have an optional `--disable-zlib` flag, but it's
> > currently not used
> > for conditional compilation and we always use zlib in libprocess,
> > and there's a requirement check in Mesos to make sure that zlib exists.
> > Should this option be removed then?
> > Or is there anyone working on a system without zlib?
> >
> > Thanks for your opinions!
> > Chun-Hung
> >
>


Re: Deprecating `--disable-zlib` in libprocess

2017-08-08 Thread Benjamin Mahler
Sorry, I think this was me, feel free to remove it from libprocess now that
it's required.

On Tue, Aug 8, 2017 at 10:57 AM, Chun-Hung Hsiao 
wrote:

> Hi all,
>
> In libprocess, we have an optional `--disable-zlib` flag, but it's
> currently not used
> for conditional compilation and we always use zlib in libprocess,
> and there's a requirement check in Mesos to make sure that zlib exists.
> Should this option be removed then?
> Or is there anyone working on a system without zlib?
>
> Thanks for your opinions!
> Chun-Hung
>


Re: Deprecating `--disable-zlib` in libprocess

2017-08-08 Thread James Peach

> On Aug 8, 2017, at 10:57 AM, Chun-Hung Hsiao  wrote:
> 
> Hi all,
> 
> In libprocess, we have an optional `--disable-zlib` flag, but it's
> currently not used
> for conditional compilation and we always use zlib in libprocess,
> and there's a requirement check in Mesos to make sure that zlib exists.
> Should this option be removed then?

Yes.

> Or is there anyone working on a system without zlib?
> 
> Thanks for your opinions!
> Chun-Hung