Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-13 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50547
---

Ship it!


LGTM. Go ahead and commit it. Thanks Time for your patience.

- Vinod Kone


On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 14, 2014, 1:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 0ac95b4 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-13 Thread Vinod Kone 


> On Aug. 14, 2014, 4:10 a.m., Vinod Kone wrote:
> > LGTM. Go ahead and commit it. Thanks Time for your patience.

Tim*


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50547
---


On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 14, 2014, 1:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 0ac95b4 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-13 Thread Timothy St. Clair 


> On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote:
> > configure.ac, line 255
> > 
> >
> > shouldn't this be different if we are using bundled "protoc" vs system 
> > installed "protoc"? i guess it is ok here because PROTOCOMPILER is only 
> > used in non-bundled case below and later in src/Makefile.am.
> > 
> > it was definitely a bit confusing to me, so maybe add a comment?
> > 
> > alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it 
> > appropriately for bundled/prefix/system cases. i'm assuming you didn't do 
> > it that way because it isn't easy to get protobuf version?
> >
> 
> Timothy St. Clair wrote:
> I updated the logic to make it similar to the others 
> 
> elif test "x$enable_bundled" = "xno"; then
>   PROTOCOMPILER="protoc"
> 
> and added a comment.
>

Let me know if you would like me to commit.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50518
---


On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 14, 2014, 1:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 0ac95b4 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-13 Thread Timothy St. Clair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated Aug. 14, 2014, 1:21 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

update per review


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/configure.ac 7b39e63 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/Makefile.am 0ac95b4 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 
  src/python/native/ext_modules.py.in 477e63d 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-13 Thread Timothy St. Clair 


> On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote:
> > i'm assuming you tested this with all 3 configurations 
> > (bundled,system,prefix) like you did for gmock?

correct. 


> On Aug. 13, 2014, 10:17 p.m., Vinod Kone wrote:
> > configure.ac, line 255
> > 
> >
> > shouldn't this be different if we are using bundled "protoc" vs system 
> > installed "protoc"? i guess it is ok here because PROTOCOMPILER is only 
> > used in non-bundled case below and later in src/Makefile.am.
> > 
> > it was definitely a bit confusing to me, so maybe add a comment?
> > 
> > alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it 
> > appropriately for bundled/prefix/system cases. i'm assuming you didn't do 
> > it that way because it isn't easy to get protobuf version?
> >

I updated the logic to make it similar to the others 

elif test "x$enable_bundled" = "xno"; then
  PROTOCOMPILER="protoc"

and added a comment.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50518
---


On Aug. 13, 2014, 7:46 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 13, 2014, 7:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 0ac95b4 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-13 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50518
---

Ship it!


i'm assuming you tested this with all 3 configurations (bundled,system,prefix) 
like you did for gmock?


configure.ac


shouldn't this be different if we are using bundled "protoc" vs system 
installed "protoc"? i guess it is ok here because PROTOCOMPILER is only used in 
non-bundled case below and later in src/Makefile.am.

it was definitely a bit confusing to me, so maybe add a comment?

alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it 
appropriately for bundled/prefix/system cases. i'm assuming you didn't do it 
that way because it isn't easy to get protobuf version?



- Vinod Kone


On Aug. 13, 2014, 7:46 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 13, 2014, 7:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 0ac95b4 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-13 Thread Timothy St. Clair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated Aug. 13, 2014, 7:46 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

rebased to origin/master


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/configure.ac 7b39e63 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/Makefile.am 0ac95b4 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 
  src/python/native/ext_modules.py.in 477e63d 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-13 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50492
---


can you rebase?

- Vinod Kone


On Aug. 13, 2014, 7:28 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 13, 2014, 7:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp d98d953 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp ce8dd9b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 87c5fc8 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e6 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   3rdparty/libprocess/include/process/defer.hpp ebe6f2d 
>   3rdparty/libprocess/include/process/future.hpp 46ae16b 
>   3rdparty/libprocess/src/process.cpp c2bee98 
>   configure.ac 8fb0a3a 
>   include/mesos/mesos.proto dc781d1 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 0ac95b4 
>   src/common/http.hpp afce7fe 
>   src/common/http.cpp 58050e9 
>   src/common/type_utils.cpp 78bfa94 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/health-check/main.cpp 6849947 
>   src/launcher/executor.cpp 64a4175 
>   src/master/http.cpp 6dd11fe 
>   src/master/master.cpp e948803 
>   src/python/native/ext_modules.py.in 477e63d 
>   src/slave/containerizer/mesos/launch.cpp 4e727a1 
>   src/slave/http.cpp 92eb348 
>   src/slave/slave.cpp 59477d5 
>   src/tests/common/http_tests.cpp 5fa51bf 
>   src/tests/health_check_tests.cpp 64fbf62 
>   src/tests/master_authorization_tests.cpp b9aa7bf 
>   src/tests/process_spawn.cpp PRE-CREATION 
>   src/tests/reconciliation_tests.cpp 8c66659 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-13 Thread Timothy St. Clair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated Aug. 13, 2014, 7:28 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

update from review to SUBST protoc and do a python check on google.protobuf.


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp d98d953 
  3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp ce8dd9b 
  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 87c5fc8 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e6 
  3rdparty/libprocess/configure.ac 7b39e63 
  3rdparty/libprocess/include/process/defer.hpp ebe6f2d 
  3rdparty/libprocess/include/process/future.hpp 46ae16b 
  3rdparty/libprocess/src/process.cpp c2bee98 
  configure.ac 8fb0a3a 
  include/mesos/mesos.proto dc781d1 
  mpi/mpiexec-mesos.in 8812ee2 
  src/Makefile.am 0ac95b4 
  src/common/http.hpp afce7fe 
  src/common/http.cpp 58050e9 
  src/common/type_utils.cpp 78bfa94 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 
  src/health-check/main.cpp 6849947 
  src/launcher/executor.cpp 64a4175 
  src/master/http.cpp 6dd11fe 
  src/master/master.cpp e948803 
  src/python/native/ext_modules.py.in 477e63d 
  src/slave/containerizer/mesos/launch.cpp 4e727a1 
  src/slave/http.cpp 92eb348 
  src/slave/slave.cpp 59477d5 
  src/tests/common/http_tests.cpp 5fa51bf 
  src/tests/health_check_tests.cpp 64fbf62 
  src/tests/master_authorization_tests.cpp b9aa7bf 
  src/tests/process_spawn.cpp PRE-CREATION 
  src/tests/reconciliation_tests.cpp 8c66659 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-13 Thread Timothy St. Clair 


> On Aug. 11, 2014, 9:16 p.m., Vinod Kone wrote:
> > src/examples/python/test-executor.in, lines 24-30
> > 
> >
> > Here and in other example python scripts below, do you want to pass 
> > PROTOBUF_EGG from configure.ac, similar to what you did with PROTOBUF_JAR? 
> > I think that would be more cleaner?
> > 
> >

So I've added a detection for the google.protobuf python module, but it doesn't 
install via prefix, it's a separate step.  I've verified by checking the rpm & 
deb packages.  

So we'll have to verify via PYTHONPATH.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50231
---


On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 11, 2014, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 39af036 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50395
---


Patch looks great!

Reviews applied: [23086]

All tests passed.

- Mesos ReviewBot


On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 11, 2014, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 39af036 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-11 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50231
---



configure.ac


Can you make sure to look in the user supplied protobuf path 
("with_protobuf") for protoc? You might also want to do a AC_SUBST to pass it 
through.



src/examples/python/test-executor.in


Here and in other example python scripts below, do you want to pass 
PROTOBUF_EGG from configure.ac, similar to what you did with PROTOBUF_JAR? I 
think that would be more cleaner?





src/examples/python/test-executor.in


I think we should test whether protobuf is present on PYTHONPATH.

How about testing if "python -c 'import google.protobuf'" works?

Longer term, the idiomatic way of doing this seems to be using 
virtualenv/pip, but lets not worry about that in this review.


- Vinod Kone


On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 11, 2014, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 39af036 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-11 Thread Timothy St. Clair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated Aug. 11, 2014, 7:11 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

rebase per request. 


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/configure.ac 7b39e63 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/Makefile.am 39af036 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 
  src/python/native/ext_modules.py.in 477e63d 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-11 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50207
---


can you rebase?

- Vinod Kone


On Aug. 8, 2014, 5:58 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 8, 2014, 5:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   Doxyfile 8bba461 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 39af036 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/master/hierarchical_allocator_process.hpp 34f8cd6 
>   src/master/master.cpp e688b41 
>   src/python/native/ext_modules.py.in 477e63d 
>   src/slave/constants.hpp 9030871 
>   src/slave/constants.cpp e1da5c0 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 938782a 
>   src/slave/slave.cpp 787bd05 
>   src/tests/allocator_tests.cpp 774528a 
>   src/tests/health_check_tests.cpp 731d944 
>   src/tests/mesos.cpp 6b5c43f 
>   src/tests/port_mapping_tests.cpp a990da3 
>   support/timed_tests.sh e060966 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-08 Thread Timothy St. Clair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated Aug. 8, 2014, 5:58 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

update from review.


Summary (updated)
-

MESOS-1174: Update system check to unbundle protobuf


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/configure.ac 7b39e63 
  Doxyfile 8bba461 
  configure.ac 8fb0a3a 
  mpi/mpiexec-mesos.in 8812ee2 
  src/Makefile.am 39af036 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in f71828d 
  src/examples/python/test-executor.in b22e7a7 
  src/examples/python/test-framework.in 64fb1dd 
  src/master/hierarchical_allocator_process.hpp 34f8cd6 
  src/master/master.cpp e688b41 
  src/python/native/ext_modules.py.in 477e63d 
  src/slave/constants.hpp 9030871 
  src/slave/constants.cpp e1da5c0 
  src/slave/containerizer/isolators/network/port_mapping.cpp 938782a 
  src/slave/slave.cpp 787bd05 
  src/tests/allocator_tests.cpp 774528a 
  src/tests/health_check_tests.cpp 731d944 
  src/tests/mesos.cpp 6b5c43f 
  src/tests/port_mapping_tests.cpp a990da3 
  support/timed_tests.sh e060966 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair