Re: Review Request 23086: Update system check to unbundle protobuf

[Timothy St. Clair]

> On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 303
> > 
> >
> > instead of hardcoding the version, is there a way to get this from 
> > 3rdparty versions.am?

So autoconf feeds forward into automake.  I don't know of a clean way to 
handle, unless it went through some common m4.

I'm hoping *this is temporary, and in next version we can remove this entirely 
and just check for protobuf, as it exists on nearly all platforms. 


> On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote:
> > configure.ac, line 347
> > 
> >
> > instead of hardcoding the version, is there a way to get this from 
> > 3rdparty versions.am?

same as previous comment. 


> On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote:
> > src/Makefile.am, line 52
> > 
> >
> > would this work if 'protoc' is installed in a prefix location?

Added a hard check in configure, it should be in the path. 


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review49532
---


On July 22, 2014, 6:14 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated July 22, 2014, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 705d19c 
>   3rdparty/libprocess/configure.ac 3a38b04 
>   configure.ac e747208 
>   mpi/mpiexec-mesos.in da0733f 
>   src/Makefile.am c216e2f 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in 569519b 
>   src/examples/python/test-executor.in 7e8875f 
>   src/examples/python/test-framework.in c4683b9 
>   src/python/setup.py.in b996dfe 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: Update system check to unbundle protobuf

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review49681
---


Bad patch!

Reviews applied: [23086]

Failed command: git apply --index 23086.patch

Error:
 error: patch failed: mpi/mpiexec-mesos.in:25
error: mpi/mpiexec-mesos.in: patch does not apply
error: patch failed: src/Makefile.am:44
error: src/Makefile.am: patch does not apply
error: patch failed: src/examples/python/test-containerizer.in:28
error: src/examples/python/test-containerizer.in: patch does not apply
error: patch failed: src/examples/python/test-executor.in:28
error: src/examples/python/test-executor.in: patch does not apply
error: patch failed: src/examples/python/test-framework.in:28
error: src/examples/python/test-framework.in: patch does not apply
error: patch failed: src/python/setup.py.in:73
error: src/python/setup.py.in: patch does not apply


- Mesos ReviewBot


On July 22, 2014, 6:14 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated July 22, 2014, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 705d19c 
>   3rdparty/libprocess/configure.ac 3a38b04 
>   configure.ac e747208 
>   mpi/mpiexec-mesos.in da0733f 
>   src/Makefile.am c216e2f 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in 569519b 
>   src/examples/python/test-executor.in 7e8875f 
>   src/examples/python/test-framework.in c4683b9 
>   src/python/setup.py.in b996dfe 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: Update system check to unbundle protobuf

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review49532
---



3rdparty/libprocess/3rdparty/Makefile.am


This is done below in lines 215 and 216. Doesn't look it's need here?



3rdparty/libprocess/configure.ac


what happens if "protobuf.jar" doesn't exist in this location? where/when 
does the error occur?



3rdparty/libprocess/configure.ac


instead of hardcoding the version, is there a way to get this from 3rdparty 
versions.am?



configure.ac


instead of hardcoding the version, is there a way to get this from 3rdparty 
versions.am?



mpi/mpiexec-mesos.in


Maybe also mention to ensure that the protobuf egg exists on the 
PYTHONPATH? Otherwise users would've no idea how to go forward.



src/Makefile.am


would this work if 'protoc' is installed in a prefix location?



src/examples/python/test-containerizer.in


ditto. expand on the comment.



src/examples/python/test-executor.in


ditto. expand on the comment.



src/examples/python/test-framework.in


ditto. expand on the comment.


- Vinod Kone


On July 22, 2014, 6:14 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated July 22, 2014, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 705d19c 
>   3rdparty/libprocess/configure.ac 3a38b04 
>   configure.ac e747208 
>   mpi/mpiexec-mesos.in da0733f 
>   src/Makefile.am c216e2f 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in 569519b 
>   src/examples/python/test-executor.in 7e8875f 
>   src/examples/python/test-framework.in c4683b9 
>   src/python/setup.py.in b996dfe 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: Update system check to unbundle protobuf

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated July 22, 2014, 6:14 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
---

Update for review, and tested on prefixed installation.  

The JAR is a needs to be supplied on PREFIX, due to installation constraints. 

The EGG is similar but is a runtime PYTHONPATH imho, and errors should be 
reported. 


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 705d19c 
  3rdparty/libprocess/configure.ac 3a38b04 
  configure.ac e747208 
  mpi/mpiexec-mesos.in da0733f 
  src/Makefile.am c216e2f 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in 569519b 
  src/examples/python/test-executor.in 7e8875f 
  src/examples/python/test-framework.in c4683b9 
  src/python/setup.py.in b996dfe 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 23086: Update system check to unbundle protobuf

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/
---

(Updated July 22, 2014, 4:54 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

assigning myself as shepherd -- vinodkone.


Bugs: MESOS-1174
https://issues.apache.org/jira/browse/MESOS-1174


Repository: mesos-git


Description
---

Enable mesos to build against system installed version of protobuf. 


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 429c956 
  3rdparty/libprocess/configure.ac 27c6ede 
  configure.ac 41f3c2b 
  mpi/mpiexec-mesos.in da0733f 
  src/Makefile.am 3c8b91a 
  src/examples/java/test-exception-framework.in 065f3c0 
  src/examples/java/test-executor.in 35559d2 
  src/examples/java/test-framework.in 9af48f9 
  src/examples/java/test-log.in 8afed0d 
  src/examples/java/test-multiple-executors-framework.in 235eb23 
  src/examples/python/test-containerizer.in 569519b 
  src/examples/python/test-executor.in 7e8875f 
  src/examples/python/test-framework.in c4683b9 
  src/python/setup.py.in b996dfe 

Diff: https://reviews.apache.org/r/23086/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 23086: Update system check to unbundle protobuf

[Timothy St. Clair]

> On July 22, 2014, 1:41 a.m., Vinod Kone wrote:
> > forgot to update the diff?

Nope I just wanted to do full builds on a couple of machines prior to submit.  

... Takes a long time. 


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review48325
---


On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated June 26, 2014, 7:31 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 429c956 
>   3rdparty/libprocess/configure.ac 27c6ede 
>   configure.ac 41f3c2b 
>   mpi/mpiexec-mesos.in da0733f 
>   src/Makefile.am 3c8b91a 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in 569519b 
>   src/examples/python/test-executor.in 7e8875f 
>   src/examples/python/test-framework.in c4683b9 
>   src/python/setup.py.in b996dfe 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: Update system check to unbundle protobuf

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review48325
---


forgot to update the diff?

- Vinod Kone


On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated June 26, 2014, 7:31 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 429c956 
>   3rdparty/libprocess/configure.ac 27c6ede 
>   configure.ac 41f3c2b 
>   mpi/mpiexec-mesos.in da0733f 
>   src/Makefile.am 3c8b91a 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in 569519b 
>   src/examples/python/test-executor.in 7e8875f 
>   src/examples/python/test-framework.in c4683b9 
>   src/python/setup.py.in b996dfe 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: Update system check to unbundle protobuf

[Timothy St. Clair]

> On July 17, 2014, 9:18 p.m., Vinod Kone wrote:
> > src/examples/java/test-exception-framework.in, line 18
> > 
> >
> > What happens when the user gives 
> > --with-protobuf=/path/to/non-standard/location?
> > 
> > is the jar still expected in /usr/share/java?
> > 
> > is it possible to plumb through the user provided protobuf path to 
> > these scripts? that seems better than silently trying to pick the jar from 
> > a standard location?
> 
> Timothy St. Clair wrote:
> Overloaded to use AC_SUBST

The logic for this is weird due to: 
https://lists.gnu.org/archive/html/bug-autoconf/2013-02/msg8.html 


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review48049
---


On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated June 26, 2014, 7:31 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 429c956 
>   3rdparty/libprocess/configure.ac 27c6ede 
>   configure.ac 41f3c2b 
>   mpi/mpiexec-mesos.in da0733f 
>   src/Makefile.am 3c8b91a 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in 569519b 
>   src/examples/python/test-executor.in 7e8875f 
>   src/examples/python/test-framework.in c4683b9 
>   src/python/setup.py.in b996dfe 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: Update system check to unbundle protobuf

[Timothy St. Clair]

> On July 17, 2014, 9:18 p.m., Vinod Kone wrote:
> > configure.ac, line 315
> > 
> >
> > would PKG_CHECK_MODULES work if protobuf is installed in a non-standard 
> > location that user specified with --with-protobuf=?

Added the check above on prefix. 


> On July 17, 2014, 9:18 p.m., Vinod Kone wrote:
> > src/examples/java/test-exception-framework.in, line 18
> > 
> >
> > What happens when the user gives 
> > --with-protobuf=/path/to/non-standard/location?
> > 
> > is the jar still expected in /usr/share/java?
> > 
> > is it possible to plumb through the user provided protobuf path to 
> > these scripts? that seems better than silently trying to pick the jar from 
> > a standard location?

Overloaded to use AC_SUBST


> On July 17, 2014, 9:18 p.m., Vinod Kone wrote:
> > src/examples/python/test-framework.in, line 31
> > 
> >
> > ditto. saying "failed" and proceeding seems weird. is the egg expected 
> > to be on the python path? if yes, we should at least tell the users so?

This actually doesn't matter so much as they user can adjust their PYTHONPATH.  
For 99% of cases where folks will use the system installation of protobuf, this 
is a non-issue.  


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review48049
---


On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated June 26, 2014, 7:31 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 429c956 
>   3rdparty/libprocess/configure.ac 27c6ede 
>   configure.ac 41f3c2b 
>   mpi/mpiexec-mesos.in da0733f 
>   src/Makefile.am 3c8b91a 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in 569519b 
>   src/examples/python/test-executor.in 7e8875f 
>   src/examples/python/test-framework.in c4683b9 
>   src/python/setup.py.in b996dfe 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23086: Update system check to unbundle protobuf

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review48049
---



configure.ac


end with period.



configure.ac


would PKG_CHECK_MODULES work if protobuf is installed in a non-standard 
location that user specified with --with-protobuf=?



mpi/mpiexec-mesos.in


period at the end.



src/examples/java/test-exception-framework.in


What happens when the user gives 
--with-protobuf=/path/to/non-standard/location?

is the jar still expected in /usr/share/java?

is it possible to plumb through the user provided protobuf path to these 
scripts? that seems better than silently trying to pick the jar from a standard 
location?



src/examples/python/test-framework.in


ditto. saying "failed" and proceeding seems weird. is the egg expected to 
be on the python path? if yes, we should at least tell the users so?


- Vinod Kone


On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated June 26, 2014, 7:31 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 429c956 
>   3rdparty/libprocess/configure.ac 27c6ede 
>   configure.ac 41f3c2b 
>   mpi/mpiexec-mesos.in da0733f 
>   src/Makefile.am 3c8b91a 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in 569519b 
>   src/examples/python/test-executor.in 7e8875f 
>   src/examples/python/test-framework.in c4683b9 
>   src/python/setup.py.in b996dfe 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>