Thanks for fixing typos on the go Qian, details matter. I've decided I share with you a lifehack I use : )
Every time I encounter a typo, I assume it has been copy-pasted, so I grep the whole folder for a misspelled word and fix all occurrences in one shot to minimize the churn. For example, inspired by your patch, I've found another instance: https://github.com/apache/mesos/blob/8483fa8a9ad79fd7e615ddd1e04373f564e97627/src/tests/slave_tests.cpp#L590 —Alex On 21 September 2016 at 02:12, <mp...@apache.org> wrote: > Repository: mesos > Updated Branches: > refs/heads/master 46379ba53 -> 9303db67c > > > Fixed a typo in `docker_containerizer_tests.cpp`. > > Review: https://reviews.apache.org/r/46264/ > > > Project: http://git-wip-us.apache.org/repos/asf/mesos/repo > Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/9303db67 > Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/9303db67 > Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/9303db67 > > Branch: refs/heads/master > Commit: 9303db67c3c7ac4206c4f35fadaa15bd07a77129 > Parents: 46379ba > Author: Qian Zhang <zhang...@cn.ibm.com> > Authored: Wed Sep 21 02:12:19 2016 +0200 > Committer: Michael Park <mp...@apache.org> > Committed: Wed Sep 21 02:12:19 2016 +0200 > > ---------------------------------------------------------------------- > src/tests/containerizer/docker_containerizer_tests.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/mesos/blob/9303db67/ > src/tests/containerizer/docker_containerizer_tests.cpp > ---------------------------------------------------------------------- > diff --git a/src/tests/containerizer/docker_containerizer_tests.cpp > b/src/tests/containerizer/docker_containerizer_tests.cpp > index 1671d45..cca3f80 100644 > --- a/src/tests/containerizer/docker_containerizer_tests.cpp > +++ b/src/tests/containerizer/docker_containerizer_tests.cpp > @@ -2404,7 +2404,7 @@ TEST_F(DockerContainerizerTest, > ROOT_DOCKER_Default_CMD_Args) > CommandInfo command; > command.set_shell(false); > > - // We should also be able to skip setting the comamnd value and just > + // We should also be able to skip setting the command value and just > // set the arguments and those should also get passed through to the > // entrypoint! > command.add_arguments(uuid); > >
