Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r66746248
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
@@ -33,66 +33,74 @@
/**
* Configuration
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r66568320
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
@@ -33,66 +33,74 @@
/**
* Configuration
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r66390266
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java
---
@@ -33,66 +33,74 @@
/**
* Configuration
GitHub user jhorcicka opened a pull request:
https://github.com/apache/metamodel/pull/103
FixedWidth EBCDIC support
METAMODEL-250 FixedWidth EBCDIC support
* Refactoring of FixedWidthReader.
* BufferedReader was replaced by BufferedInputStream (support for files
Github user jhorcicka commented on the issue:
https://github.com/apache/metamodel/pull/103
I separated EbcdicConfiguration (extends FixedWidthConfiguration) and
EbcdicReader (extends FixedWidthReader).
---
If your project is set up for it, you can reply to this email and have your
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r74198110
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/EbcdicReader.java ---
@@ -26,13 +26,17 @@
*/
class EbcdicReader extends
GitHub user jhorcicka opened a pull request:
https://github.com/apache/metamodel/pull/121
FixedWidthReader diacritics bug fix
Refactoring of FixedWidthReader in PR
https://github.com/apache/metamodel/pull/103 introduced a bug related to
charset (which was not used). So, input
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/103#discussion_r73650071
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
---
@@ -18,78 +18,235 @@
*/
package
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r73656991
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
---
@@ -85,6 +92,15 @@ public FixedWidthReader(InputStream
Github user jhorcicka commented on the issue:
https://github.com/apache/metamodel/pull/121
I closed this PR because of a bad source, I will create a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jhorcicka opened a pull request:
https://github.com/apache/metamodel/pull/122
METAMODEL-1109: FixedWidthReader diacritics bug fix
Refactoring of FixedWidthReader in PR #103 introduced a bug related to
charset (which was not used). So, input containing diacritic
Github user jhorcicka commented on the issue:
https://github.com/apache/metamodel/pull/123
According to
https://docs.oracle.com/cd/B28359_01/server.111/b28318/datatype.htm#i3253 I
tried CHAR, NCHAR, CLOB, NCLOB, VARCHAR2 and NVARCHAR2. In these cases when an
empty string
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r73830409
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
---
@@ -43,6 +47,7 @@
private final boolean
GitHub user jhorcicka opened a pull request:
https://github.com/apache/metamodel/pull/123
METAMODEL- Empty string treatment in Oracle
Fixes Oracle '' = null problem. In OracleQueryRewriter empty string operand
is reaplaced by null.
You can merge this pull request into a Git
GitHub user jhorcicka opened a pull request:
https://github.com/apache/metamodel/pull/179
Feature/neo4j column types
This PR adds column types to the neo4j table definitions. In the previous
version all column types were treated as Strings.
---
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190797849
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache
Github user jhorcicka commented on the issue:
https://github.com/apache/metamodel/pull/179
@arjansh:
* JUnit test was added.
* I decided to use the simple if-then block for the column type
decision.
---
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r191188566
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache
Github user jhorcicka commented on the issue:
https://github.com/apache/metamodel/pull/179
@arjansh, @kaspersorensen: Updated.
I plan to create another PR to fix some code style issues like missing
"final" keywords after this one is accepted.
---
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r191153847
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r191154706
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache
22 matches
Mail list logo
