[GitHub] metamodel issue #124: Added code to remove TIMESTAMP tokens from SQLServer q...

2017-08-10 Thread kaspersorensen
Github user kaspersorensen commented on the issue:

https://github.com/apache/metamodel/pull/124
  
I vote to close this, unless anyone would like to implement the needed 
tests and verifications that where asked for in review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metamodel issue #124: Added code to remove TIMESTAMP tokens from SQLServer q...

2016-08-16 Thread kaspersorensen
Github user kaspersorensen commented on the issue:

https://github.com/apache/metamodel/pull/124
  
Hi Harris,

We will do it as quickly as possible, but not quicker than allowing us to 
vet the change properly :-) And I would guess that you also would need us to 
release the fix soon then? Speaking from experience, you might want to mitigate 
that dependency risk a bit. If the deadline is soon I suggest you to 
temporarily depend on your own fork of the project here on GitHub. You should 
be able to make modifications and do an internal release or something like that 
- depending on how close and important that deadline is of course.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metamodel issue #124: Added code to remove TIMESTAMP tokens from SQLServer q...

2016-08-16 Thread olafgarten
Github user olafgarten commented on the issue:

https://github.com/apache/metamodel/pull/124
  
Hi, If this is all okay can it be merged as soon as possible, we have a 
customer deadline very soon and need this to be done as quickly as possible.

Thanks,
Harris Mirza


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---