GitHub user tomatophantastico opened a pull request:
https://github.com/apache/metamodel/pull/154
Checkstyle intergration (and collections)
This pull is on top of pull request #153.
I opened a new pull request as this is technically a new feature, #153 is
however included in this one. It is not as large as it seems. Only the last 4
commits are relevant.
Integrates checkstyle into the maven test phase: so when ever mvn test is
called, checkstyle is run and fails on violations.
I only activated three rules:
unused imports -> self-explanatory
import order -> enforce eclipse ordering, therefore smaller commits, when
using different IDEs
licence -> rat checks if present, this one however enforces 1:1 identity
with the context of the text file. I found and corrected some deviations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tomatophantastico/metamodel feature/checkstyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
commit ab5c9482dd2efbb4cdc17402fddabfed05915ff2
Author: JoÌrg Unbehauen
Date: 2017-07-27T11:01:26Z
first round of refactoring
commit 2d156bcd0721f436ea42c3bc4a0af314375873b4
Author: JoÌrg Unbehauen
Date: 2017-07-27T16:05:40Z
now all compiling
commit 7f76973edc8e9e72bd404484585c11f156766926
Author: JoÌrg Unbehauen
Date: 2017-07-27T16:18:12Z
less intrusive conversion, due to failing test cases
commit dd07999449168f2f767e68b75d90943e38028eab
Author: JoÌrg Unbehauen
Date: 2017-07-28T10:16:07Z
removing the getMutableTables and casting instead
commit 44571b97562d593f5a2ac7748179464f906b269d
Author: JoÌrg Unbehauen
Date: 2017-07-28T10:16:28Z
include call to loading facilities
commit 5a9d2d146cd659b7284a65d617d7362b1ce7a5bc
Author: JoÌrg Unbehauen
Date: 2017-07-28T12:15:53Z
removed unnecessary braces
commit 056d4d18a9284c5f037ed80e00d6c16fab0c25e1
Author: JoÌrg Unbehauen
Date: 2017-07-28T12:19:34Z
removed unnecessary toArray conversion
commit 6234fb4ab7fbf53c58b174e58c2435bb8079b54a
Author: JoÌrg Unbehauen
Date: 2017-07-28T16:27:34Z
guava now in test scope of core
commit e387a5ae62b500b467fcdae3cac0513af57fc920
Author: JoÌrg Unbehauen
Date: 2017-08-02T12:39:31Z
organized the imports
commit 725e2102b439bbd323a44d1f6e2efb2720371b86
Author: JoÌrg Unbehauen
Date: 2017-08-02T13:05:33Z
previously forgotten
commit 840aea410c254e29253d46983629de03843297af
Author: JoÌrg Unbehauen
Date: 2017-08-02T13:14:20Z
rearranged to eclipse import style
commit d24c3e5849052560e69241c4d4db3f9a99a65f78
Author: Kasper Sørensen
Date: 2017-08-04T03:32:36Z
Fixed unused import and deprecation warnings
commit a07b8fe100925c9e4ed328b80319e48c72045dda
Author: tomatophantastico
Date: 2017-08-04T10:12:26Z
Merge pull request #1 from kaspersorensen/feature/collectionsInterfaces
Fixed unused import and deprecation warnings
commit c4acebd5d3911bc208c3fd919a8cf7894b371c00
Author: JoÌrg Unbehauen
Date: 2017-08-04T13:31:21Z
merged master
commit cebf2e1833f58f729a47ef0894a9c876a8b44879
Author: JoÌrg Unbehauen
Date: 2017-08-02T12:40:27Z
initial check style checkin
commit b371c0a6a5097c8c047860a4ca29cd09a2bfa421
Author: JoÌrg Unbehauen
Date: 2017-08-02T13:03:40Z
include javadoc in analysis
commit 28b58e078c443a89222049d43bdc85c8d209961d
Author: JoÌrg Unbehauen
Date: 2017-08-02T15:43:18Z
check style for header and eclipse import order
commit 4abb5bc7266483b0e3977a4730ed31f18312259c
Author: JoÌrg Unbehauen
Date: 2017-08-02T15:44:08Z
small fixes to import, import order or license header to keep up with the
check style rules
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
