[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-02-26 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/942 @nickwallen Thanks for the review, I have incorporated your comments. ---

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

2018-02-26 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/940 I tested this in full dev and worked as expected. +1 ---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-26 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/938 The Apache logo image used is a bit outdated. Could you swap it with the latest? Looks like it's at https://www.apache.org/foundation/press/kit/#links. I can only find it from the

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-26 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/938 Thanks @justinleet for the pointer. I have made a change to use the Powered By logo instead of the foundation logo with feather, since I thought this looked better. I also added a direct link to

[GitHub] metron issue #934: METRON-1423: Ambari work to handle Solr configuration

2018-02-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/934 +1 by inspection ---

[GitHub] metron pull request #942: METRON-1461: Modify the MIN, MAX Stellar methods t...

2018-02-26 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/942#discussion_r170598354 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/Ordinal.java --- @@ -0,0 +1,24 @@ +/** + *

[GitHub] metron pull request #942: METRON-1461: Modify the MIN, MAX Stellar methods t...

2018-02-26 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/942#discussion_r170597762 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -37,17 +35,23 @@ *

[GitHub] metron pull request #942: METRON-1461: Modify the MIN, MAX Stellar methods t...

2018-02-26 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/942#discussion_r170595688 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -37,17 +35,23 @@ *

[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6

2018-02-26 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/933 FYI - After the last commit, I spun-up the CentOS environment again; validated the Alerts UI is receiving data, ran the Metron Service Check successfully. All is well. ---

[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6

2018-02-26 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/933 When creating the Ubuntu environment a while back, I created an Ansible role that enables swap space. (In the base Ubuntu image, swap space is not enabled.) It was easy enough to reuse that in