Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/938
+1 from me as well, thanks @anandsubbu!
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/940
I'd hold on merging this until we can get this tested at some decent scale.
Unless it already has been? Otherwise, I don't see a need to merge this until
we know it actually addresses a
Github user anandsubbu commented on the issue:
https://github.com/apache/metron/pull/938
Thanks all.
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/936
The PR title here doesn't match the
[JIRA](https://issues.apache.org/jira/projects/METRON/issues/METRON-1450?filter=allopenissues)
but as long as we account for that during merging, I'm a +1 on
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/938
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/938
+1 as well, looks great
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r171015228
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchRequest.java
---
@@ -101,16 +99,16 @@ public void
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/853
@merrimanr this looks much better. I'm +1 via inspection pending any
further feedback from @ottobackwards.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/944
+1 These corrections should greatly improve performance.
---
Github user MohanDV commented on the issue:
https://github.com/apache/metron/pull/936
Bump. Can anyone offer a binding +1 ? I Would like to get this in.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/936
+1 Thanks for correcting this @MohanDV. This looks good.
Let's give @JonZeolla a chance to respond before we merge this.
---
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/944
METRON-1463: Adjust the groupings and shuffles in enrichment to be more
efficient
## Contributor Comments
Currently there are some deficiencies in our grouping approach in the
enrichment
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/938
Where is that powered by apache logo from? Are we sure it doesn't mean
that the apache web server serves it up?
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/938
Yeah, I thought that was more third party thing. Admittedly, this seems at
(high) risk of becoming a bikeshed. I'd probably rather just use the main mark
Github user anandsubbu commented on the issue:
https://github.com/apache/metron/pull/938
Roger that. Here's the new look. Let me know if this looks ok @justinleet
and @cestella .
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/938
+1, pending Travis. I think any look complaints after this are follow-on,
given that this addresses the main issues we wanted and has the updated mark.
---
Hey list,
Has anyone gotten full-dev automatically set up on Windows by any chance
or are we all using Linux & macOS?
17 matches
Mail list logo
