Re: [DISCUSS] Remove `/api/v1/update/replace` endpoint
+1 to that Nick On Fri, Dec 7, 2018 at 11:13 AM Nick Allen wrote: > Heads up - I have not received a response from anyone for about 3 days. I > am going to take that as no one has a problem with this change. I will > likely merge the PR today. > > > > On Tue, Dec 4, 2018 at 4:05 PM Nick Allen wrote: > > > PR #1284 completely removes the `/api/v1/update/replace` endpoint. This > > endpoint is not being used by any other services in Metron currently. > > > > As part of the work I am doing to allow Elasticsearch to auto-generate > the > > document ID, I would have had to make code changes to this endpoint to > > continue to support it. Rather than doing that, I opted to remote it, > as I > > believe it is dead code. > > > > * I want to make sure that no one in the community is using this endpoint > > for other purposes. If you are, please respond on this thread. > > > > * Does anyone think we should deprecate this before completely removing > > it? Personally, I do not think it is necessary, but if anyone disagrees > > please voice your opinion. > > > > > > > > > > [1] https://github.com/apache/metron/pull/1284 > > >
Re: [DISCUSS] Remove `/api/v1/update/replace` endpoint
Heads up - I have not received a response from anyone for about 3 days. I am going to take that as no one has a problem with this change. I will likely merge the PR today. On Tue, Dec 4, 2018 at 4:05 PM Nick Allen wrote: > PR #1284 completely removes the `/api/v1/update/replace` endpoint. This > endpoint is not being used by any other services in Metron currently. > > As part of the work I am doing to allow Elasticsearch to auto-generate the > document ID, I would have had to make code changes to this endpoint to > continue to support it. Rather than doing that, I opted to remote it, as I > believe it is dead code. > > * I want to make sure that no one in the community is using this endpoint > for other purposes. If you are, please respond on this thread. > > * Does anyone think we should deprecate this before completely removing > it? Personally, I do not think it is necessary, but if anyone disagrees > please voice your opinion. > > > > > [1] https://github.com/apache/metron/pull/1284 >
[DISCUSS] Remove `/api/v1/update/replace` endpoint
PR #1284 completely removes the `/api/v1/update/replace` endpoint. This endpoint is not being used by any other services in Metron currently. As part of the work I am doing to allow Elasticsearch to auto-generate the document ID, I would have had to make code changes to this endpoint to continue to support it. Rather than doing that, I opted to remote it, as I believe it is dead code. * I want to make sure that no one in the community is using this endpoint for other purposes. If you are, please respond on this thread. * Does anyone think we should deprecate this before completely removing it? Personally, I do not think it is necessary, but if anyone disagrees please voice your opinion. [1] https://github.com/apache/metron/pull/1284
