[GitHub] metron issue #585: METRON-936: Fixes to pcap for performance and testing

2017-05-17 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/585 +1 by inspection, great addition. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron issue #585: METRON-936: Fixes to pcap for performance and testing

2017-05-16 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/585 I see that. re: keys and methods for retrieving and saving them. I'll save refactoring and cleaning that up to a separate PR. --- If your project is set up for it, you can reply to this email and

[GitHub] metron issue #585: METRON-936: Fixes to pcap for performance and testing

2017-05-16 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/585 Regarding the test data, it's not a sequence file in the format suitable for reading in PcapInspector. Depending on the test case, we construct the appropriate kafka representation. The value is

[GitHub] metron issue #585: METRON-936: Fixes to pcap for performance and testing

2017-05-16 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/585 @mmiklavc it depends on which test case you're talking about. We have two modes of operation in the pcap topology and 2 test cases in the integration test and these are defined by the flux

[GitHub] metron issue #585: METRON-936: Fixes to pcap for performance and testing

2017-05-16 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/585 I found some additional issues with error handling in the HDFSWriterCallback. So I fixed this to throw an IllegalArgumentException when the key is null, but that revealed further problems in our