[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/690 Perfect, ty. ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 Done, let me know if the changes are sufficient @JonZeolla ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 @JonZeolla this should be set ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/690 This looks reasonable to me @ottobackwards. I'm +1 pending any further work per @JonZeolla's comments. Thanks for the contribution! ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 Hopefully it is all set @JonZeolla ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 Sorry , it has been a while, I'll try to get it set ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/690 Can you deconflict? I'd like to retest and review your questions again, but at a quick glance I think my prior suggestions stand, and for your NOTICE question, I'm not sure. ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 I have refactored this to be stellar centric. We will create a second archive for the stand alone shell from stellar-common. I also documented it in the stellar README.md. The questions about NOTICE, LIC, README for deployment still apply. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/690 Right, I think the disconnect is that I would envision a stellar shell with metron stellar functions added as libs, as you suggested. That's why I was thinking we would doc in stellar-common, I missed that this includes management/profiler functions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 I'm going to close this and refactor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 @JonZeolla I don't want to document it in the stellar-common module. Stellar is being broken out of metron. The packaging of stellar as a shell, with the likely inclusion of metron-* stellar functions is a 'metron' thing. not a stellar thing. At least that is what I'm thinking. So this is a metron custom deployment of the shell. I could change it to the default stand alone deployment of the shell for stellar, but I didn't think that was the right way to start out, at the time at least. We **could** do it as the default archive of stellar common, and then do **another** archive of metron stellar jars. So the usage would be: unpack shell package unpack metron-stellar-package into lib --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 bump - any comments on this? Any ideas for deployment? can we leave for later? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user cestella commented on the issue: https://github.com/apache/metron/pull/690 I just want to make sure that we didn't break backwards compatibility and have the shell not deployed as part of the mpack, I guess ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 Casey, this adds a new packaging subfolder -> archive, and generates a new artifact ( the tar.gz ). It does not effect the current deployment of the stellar shell as a part of metron. I put it in deployment / packaging as default for 2 reasons: 1. If we do include profiler/management etc that makes this a metron thing and not a stellar thing 2. We don't have any packaging outside of deployment Both of those things are up for discussion. an RPM of the shell for RPM deployment to NON metron nodes could be a follow on. --- *Comments from [Reviewable](https://reviewable.io:443/reviews/apache/metron/690#-:-KrW6vGRzz8e1jzn5S1b:b-6c7w3h)* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 @JonZeolla Thanks for the review! There are several questions in the description that I think need to fall out of the review, one of them is where or how to document this. Any ideas? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
