[GitHub] metron issue #727: METRON-1146: Add ability to parse JSON string into JSONOb...

2017-09-12 Thread cestella 
Github user cestella commented on the issue:

https://github.com/apache/metron/pull/727
  
+1 by inspection, great job!


---

[GitHub] metron issue #727: METRON-1146: Add ability to parse JSON string into JSONOb...

2017-09-12 Thread ottobackwards 
Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/727
  
+1 by inspection


---

[GitHub] metron issue #727: METRON-1146: Add ability to parse JSON string into JSONOb...

2017-09-12 Thread anandsubbu 
Github user anandsubbu commented on the issue:

https://github.com/apache/metron/pull/727
  
Thanks very much @ottobackwards ! 

@nickwallen , pushed latest commit with the functions renamed. Please have 
a look.


---

[GitHub] metron issue #727: METRON-1146: Add ability to parse JSON string into JSONOb...

2017-09-12 Thread anandsubbu 
Github user anandsubbu commented on the issue:

https://github.com/apache/metron/pull/727
  
Hi @nickwallen thank you. Sure, I see value in simplifying the naming. How 
does `TO_JSON_OBJECT`, `TO_JSON_MAP` and `TO_JSON_LIST` sound?


---

[GitHub] metron issue #727: METRON-1146: Add ability to parse JSON string into JSONOb...

2017-09-12 Thread nickwallen 
Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/727
  
I have not reviewed the code, but I definitely like the functionality 
@anandsubbu .  What do you think about simplifying the name to `TO_JSON` or 
something like that?


---