[GitHub] metron issue #909: METRON-1429: SearchIntegrationTest refactor
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/909 @cestella You're right about that - the general goodness. We (I) had made the mistake of doing some test refactoring in the ES upgrade branch that would have been better done in a separate PR, committed to master, and then pulled into the ES branch. Splitting out improvements/refactorings the way Ryan did here means everyone gets the benefit, and further changes or enhancements don't get mangled in repeated merges in the Solr feature branch. ---
[GitHub] metron issue #909: METRON-1429: SearchIntegrationTest refactor
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/909 +1 pending travis ---
[GitHub] metron issue #909: METRON-1429: SearchIntegrationTest refactor
Github user cestella commented on the issue: https://github.com/apache/metron/pull/909 Sounds good, +1 Good work here, that test was confusing. ---
[GitHub] metron issue #909: METRON-1429: SearchIntegrationTest refactor
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/909 I think this is useful outside of any Solr work and I intended for it to go into master. ---
[GitHub] metron issue #909: METRON-1429: SearchIntegrationTest refactor
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/909 @cestella This is going into master per the merge notes, right? ---
[GitHub] metron issue #909: METRON-1429: SearchIntegrationTest refactor
Github user cestella commented on the issue: https://github.com/apache/metron/pull/909 Should this be against master or should this be committed against the Solr branch? It *seems* like this is general purpose goodness and maybe fits in master, but I wanted to double check. ---
