[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-27 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/938 Thanks all. ---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-27 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/938 +1 from me as well, thanks @anandsubbu! ---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-27 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/938 +1 as well, looks great ---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-27 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/938 +1, pending Travis. I think any look complaints after this are follow-on, given that this addresses the main issues we wanted and has the updated mark. ---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-27 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/938 Roger that. Here's the new look. Let me know if this looks ok @justinleet and @cestella .

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-27 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/938 Yeah, I thought that was more third party thing. Admittedly, this seems at (high) risk of becoming a bikeshed. I'd probably rather just use the main mark

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-27 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/938 Where is that powered by apache logo from? Are we sure it doesn't mean that the apache web server serves it up? ---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-26 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/938 Thanks @justinleet for the pointer. I have made a change to use the Powered By logo instead of the foundation logo with feather, since I thought this looked better. I also added a direct link to

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-26 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/938 The Apache logo image used is a bit outdated. Could you swap it with the latest? Looks like it's at https://www.apache.org/foundation/press/kit/#links. I can only find it from the

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

2018-02-25 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/938 Thank you @mmiklavc and @nickwallen for your reply on the dev list. Any feedback on this PR? ---