[GitHub] metron issue #948: METRON-1468: Add support for apache/metron-bro-plugin-kaf...
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/948 +1 ---
[GitHub] metron issue #948: METRON-1468: Add support for apache/metron-bro-plugin-kaf...
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/948 I agree, updated the script and readme. ---
[GitHub] metron issue #948: METRON-1468: Add support for apache/metron-bro-plugin-kaf...
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/948 Other than that little nit, it works great though. Thanks @JonZeolla ---
[GitHub] metron issue #948: METRON-1468: Add support for apache/metron-bro-plugin-kaf...
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/948 When I got to the point of selecting the repo, I was unsure of what to type for the Bro Plugin repo. ``` $ ./metron-pr948/dev-utilities/committer-utils/prepare-commit ...using settings from /Users/nallen/.metron-prepare-commit which repo? [metron]: ``` Do you think we could make this more obvious somehow? Maybe something like the following? ``` $ ./metron-pr948/dev-utilities/committer-utils/prepare-commit ...using settings from /Users/nallen/.metron-prepare-commit which repo? [1]: [1] metron [2] metron-bro-plugin-kafka ``` This would, as it does now, default to `[1] metron`. ---