[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...
Github user xyztdanid4 commented on the issue: https://github.com/apache/metron/pull/952 @merrimanr As we agreed yesterday I did the required changes in the pom xml-s. I had to update the node dependency of the projects, otherwise the build was failed, cause one of the dependencies was dependent on node8. There is no equivalent command to npm --prefix in yarn, so I updated the readme to just cd into that directory where the install step is required. When we build the metron-alert project (angular4), there was an error, mainly because angular4 uses AOT as default builder strategy. I fixed this by addig env=prod to the package json. ---
[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/952 I think we are on board with switching to yarn so no concerns there. There was a discussion on it but if anyone now feels differently, speak up. Sounds like we still have a lot of work to do. I would suggest reviewing the metron-config and metron-alerts READMEs and update them appropriately. In fact, I would just search the whole project for npm commands and switch to yarn as needed. You will definitely need to run this up in full dev and verify everything works. Our maven front end plugin will also need to be reviewed and updated: https://github.com/eirslett/frontend-maven-plugin. We use that in metron-config and metron-alerts. ---
[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...
Github user xyztdanid4 commented on the issue: https://github.com/apache/metron/pull/952 @merrimanr although it should work with npm as well, cause then it will use the package.json to install the dependencies. ---
[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...
Github user xyztdanid4 commented on the issue: https://github.com/apache/metron/pull/952 @merrimanr Yes this is the right way to switch to yarn. Yes we have install yarn locally. I did not know that we have so much dependency on npm. But for me it was hard to add new dependencies using npm, cause it was constantly failing. And yes I would recommend to use yarn, at least for the front end builds. What yarn does is that reduces the possibility of version mismatch of the dependencies by importing the dependencies subdependency in the right version. So yes we have to use yarn commands if we merge this PR. ---
[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...
Github user xyztdanid4 commented on the issue: https://github.com/apache/metron/pull/952 @merrimanr ---
[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/952 I'm having trouble understanding what this PR actually does. I see that package-lock.json was removed and yarn.lock was added. Is that all that's needed to switch to yarn? Do we need to also update our build commands to match those [here](https://yarnpkg.com/en/docs/usage)? What considerations are there for development? Are we supposed to be using yarn commands now instead of npm commands? Do we need to install yarn locally? We probably need to review our documentation and rpm build processes too. We use npm all over the place. ---
[GitHub] metron issue #952: Metron-1480 Add yarn as default build tool for the fronte...
Github user xyztdanid4 commented on the issue: https://github.com/apache/metron/pull/952 @simonellistonball I am not sure. Probably no. ---
[GitHub] metron issue #952: Metron-1480 Add yarn as default build tool for the fronte...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/952 Have the dependencies, License and Notices files been updated? ---
