Re: [DISCUSS] Merging Solr feature branch (METRON-1416) into master

Thank you, Justin. Great job on the merge 26.06.2018, 14:20, "Justin Leet" : > The Solr feature branch is in now in master. Note that there is no > METRON-1416 commit in the logs because all subtasks are committed under > their own JIRA and are in the history to maintain attribution. > > On

Re: [DISCUSS] Merging Solr feature branch (METRON-1416) into master

The Solr feature branch is in now in master. Note that there is no METRON-1416 commit in the logs because all subtasks are committed under their own JIRA and are in the history to maintain attribution. On Tue, Jun 26, 2018 at 1:26 PM Otto Fowler wrote: > +1 > > > On June 26, 2018 at 11:43:39,

Re: [DISCUSS] Merging Solr feature branch (METRON-1416) into master

+1 On June 26, 2018 at 11:43:39, Justin Leet (justinjl...@gmail.com) wrote: The PR has two +1's at this point (and I'm implicitly +1). In the interest of full disclosure, both are from people who made contributions of varying degrees to the branch. Are there any objections to merging the

Re: [DISCUSS] Merging Solr feature branch (METRON-1416) into master

The PR has two +1's at this point (and I'm implicitly +1). In the interest of full disclosure, both are from people who made contributions of varying degrees to the branch. Are there any objections to merging the feature branch into master at this point? On Fri, Jun 22, 2018 at 1:12 PM Justin

Re: [DISCUSS] Merging Solr feature branch (METRON-1416) into master

The (formerly) active PRs are now merged in and closed. We don't seem to have defined way to merge a feature branch into master (unless I missed it), so I went ahead and opened a PR against the parent ticket. Please see #1076 . I haven't fleshed out

Re: [DISCUSS] Merging Solr feature branch (METRON-1416) into master

I think that we should merge now, but I’m perhaps biased since I did one of the hard merges. I think that since the major outstanding bug is being worked and we are otherwise feature complete, the feature branch did its job and we are ready to merge. On Thu, Jun 21, 2018 at 10:21 Justin Leet