[GitHub] incubator-metron issue #188: METRON-227 (Time based flushing)

2016-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/188 Whoops, forgot, we should probably have a unit test addition given this functionality. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-metron pull request #188: METRON-227 (Time based flushing)

2016-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/188#discussion_r70704170 --- Diff: metron-platform/metron-integration-test/src/main/config/zookeeper/global.json --- @@ -7,10 +7,12 @@ "solr.collection": "metron",

[GitHub] incubator-metron pull request #188: METRON-227 (Time based flushing)

2016-07-13 Thread ajayydv
GitHub user ajayydv opened a pull request: https://github.com/apache/incubator-metron/pull/188 METRON-227 (Time based flushing) METRON-227 (Time based flushing) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-metron issue #187: Metron 321

2016-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/187 +1. In the future can you please name the PR starting with the full JIRA name followed by the description, like so: "METRON-321: Add items to .gitignore". The full JIRA name (with the

[GitHub] incubator-metron pull request #188: METRON-227 (Time based flushing)

2016-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/188#discussion_r70703025 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/writer/BulkWriterComponent.java --- @@ -34,21 +34,37 @@

[GitHub] incubator-metron pull request #188: METRON-227 (Time based flushing)

2016-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/188#discussion_r70704522 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/writer/BulkWriterComponent.java --- @@ -103,10 +115,21 @@ public

[GitHub] incubator-metron issue #188: METRON-227 (Time based flushing)

2016-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/188 Great contribution, thanks! I had a few comments, but good job. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-metron issue #186: METRON-298 Remove the effective_tld_names.dat f...

2016-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/186 Just for posterity, I ran it up in vagrant --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #186: METRON-298 Remove the effective_tld_names.dat f...

2016-07-13 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/186 I've been trying, but it's AWS is fighting me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not