[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-02-02 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @justinleet thanks for the catch. Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-02-03 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 Hi @JonZeolla , you have good eyes! I missed those cases, which are only visible where H1 headers have been used in the *body* of the document, AND there are TOC or other internal

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-02-03 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @JonZeolla you pushed my perfectionist button :-) This latest push fixes the problem with anchors on H1 headers. The generated html is unchanged except for the insertion of anchor

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-02-03 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @cestella , as Release Manager you can choose whether to accept this last commit (if @JonZeolla has time to review it) or just roll in the previous change set. I'm ok either way

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-31 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 Okay, @JonZeolla , @justinleet , and others, the awk script has been replaced by a python script. The results of the dialect fix-up are identical to the awk script's results across

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-31 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 BTW, the instructions for use are unchanged, since the fix-up script is invoked from within the bin/generate-md.sh script. --- If your project is set up for it, you can reply

[GitHub] incubator-metron issue #442: METRON-322 Global Batching and Flushing

2017-02-06 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/442 Gap fixed. (Added fix to decrease flush latency for most queues.) Please give preliminary review feedback, as requested in the PR Intro. --- If your project is set up

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479152 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479385 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-02-06 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 Thank you all for your efforts reviewing this. @cestella , I have rebased to master and re-validated. The only conflict was a trivial edit in one doc file. Per

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479325 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479221 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479068 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99479413 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: add stellar external functions feature (...

2017-02-05 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r99493097 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #442: METRON-322 Global Batching and Flushing

2017-02-05 Thread mattf-horton
Github user mattf-horton closed the pull request at: https://github.com/apache/incubator-metron/pull/442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron issue #442: METRON-322 Global Batching and Flushing

2017-02-05 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/442 I found a gap in my logic. Will re-open after fixing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-metron pull request #442: METRON-322 Global Batching and Flushing

2017-02-05 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/442 METRON-322 Global Batching and Flushing DO NOT INTEGRATE YET. This is a preliminary review request. This Jira Ticket is to add timeout flushing to all Writers that do batch

[GitHub] incubator-metron issue #408: METRON-608 Mpack to install a single-node test ...

2017-01-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/408 Hi @dlyle65535 , from a design perspective, I totally agree that we should have a single MPack that works on any size cluster, and I hope to replace both the 4(+)-node and single-node

[GitHub] incubator-metron issue #408: METRON-608 Mpack to install a single-node test ...

2017-01-25 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/408 @JonZeolla , I removed the obsolete comments about MySQL installation in Mpack. Thanks for the suggestion. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-metron issue #425: METRON 609 Enhance Mpack to handle single-node ...

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/425 Thanks, @dlyle65535 . Couple more comments: - Also included is the small change proposed in METRON-641 to use {0} instead of {} in python format strings in kibana_master.py

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @justinleet , No, the advanced awk features are heavily used. Well, I guess this is a good reason to convert to a python script after all. I'll give it whack. --- If your project

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @JonZeolla , interesting. That would be equivalent to gawk version 3.1.5 or 3.1.6. I see now that my updated awk is from a homebrew installation. Would you be willing

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @justinleet , yah, that's typical of what I called "paragraph munching". The triple-backtick delimiter is being consumed as text, then interpreted as an empty doubl

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @justinleet , hi, sorry our responses crossed. Looks like the old awk is rejecting the regex, probably the `[:blank:]` notation? So yah, need an updated awk. Is that an acceptable

[GitHub] incubator-metron pull request #429: METRON-660 [Umbrella] up-to-date version...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/429#discussion_r98521687 --- Diff: site-book/src/site/site.xml --- @@ -0,0 +1,124 @@ + + +http://maven.apache.org/DECORATION/1.3.0; --- End diff

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 @justinleet and @JonZeolla , the issues you are describing with bullets and codeblocks sound like things I worked hard to fix, and they work on my system. Please see new screenshot

[GitHub] incubator-metron pull request #429: METRON-660 [Umbrella] up-to-date version...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/429#discussion_r98531347 --- Diff: site-book/src/site/site.xml --- @@ -0,0 +1,124 @@ + + +http://maven.apache.org/DECORATION/1.3.0; --- End diff

[GitHub] incubator-metron issue #429: METRON-660 [Umbrella] up-to-date versioned docu...

2017-01-30 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/429 Guys, to make it easier to distinguish between tool problems vs content bugs, I've uploaded a tarball of the full site-book as built on my platform, at [site-book_0.3.0_20170130

[GitHub] incubator-metron issue #408: METRON-608 Mpack to install a single-node test ...

2017-01-25 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/408 @dlyle65535 , I'll be happy to share my wip. It will take me a few hours to brush it off, then I'll post it as a PR referring to [METRON-609](https://issues.apache.org/jira/browse

[GitHub] incubator-metron issue #408: METRON-608 Mpack to install a single-node test ...

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/408 @dlyle65535 , please see https://github.com/apache/incubator-metron/pull/425 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

2017-01-25 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/405 Let's do this, but need to also fix the other three places in this file where '{}' is used with format method. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-metron pull request #425: METRON 609 Enhance Mpack to handle singl...

2017-01-26 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/425 METRON 609 Enhance Mpack to handle single-node and small-cluster installs of Elasticsearch This PR is not ready for prime time, but is provided for ease of access to work

[GitHub] incubator-metron issue #425: METRON 609 Enhance Mpack to handle single-node ...

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/425 @dlyle65535 , I see that changes necessary to single-node, in slave.py and elastic_slave.py, were in my METRON-634 commit rather than the METRON-609 commit. Sorry for the oversight

[GitHub] incubator-metron issue #423: METRON-270: Add Zeppelin to the platform

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/423 @nickwallen , glad you got it working. Just BTW, the [wiki page](https://cwiki.apache.org/confluence/display/METRON/Metron+with+HDP+2.5+bare-metal+install) recently posted by Dima

[GitHub] incubator-metron issue #425: METRON 609 Enhance Mpack to handle single-node ...

2017-01-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/425 @dlyle65535 , makes sense to me. METRON-671 is very important for rationalizing our install scenarios, and clearly these fixes can be pipelined as you describe. I'm super glad

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-20 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 I just checked, and this PR branch rebases to master without conflict, which I think means it will merge without conflict. If anyone would consider committing it, let me know if you

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-17 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 Hi @JonZeolla , @ottobackwards , @cestella , @mmiklavc , Thanks to all of you for looking at this. Taking issues in order: 1. Absolutely right, no reason to have site.xml.bak

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-16 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 @JonZeolla , sorry traveling yesterday. Will look at it this evening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-17 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 I've tested it to completion on both Centos 6 and 7. It works and generates identical src and site file trees. I also tested the trap on SIGINT, which worked on all three platforms

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-17 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 I have pushed fixes for all of the above. To fix item 3 I had to change history, so you'll need to "pull -f" to update an existing image. I tested code

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-16 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 @JonZeolla , thanks for the suggestions. Incorporated the SIG traps and better exit codes, as well as improvements to the 'find -exec' error catching logic. Also added 'set -e

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

2017-02-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/405 +1 on the fix btw. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #406: METRON-642 Correct path to ES gc log file

2017-02-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/406 @DimDroll , yes, I just noticed in PR#405 that the comments were being correctly cc'ed to Jira even tho the title was different. Don't know. Maybe the received wisdom about

[GitHub] incubator-metron issue #406: METRON-642: Correted path to ES gc log file

2017-02-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/406 @DimDroll , please note the title of this PR is different from the title of the Jira. That means comments here will *not* be correctly cc'ed to the Jira. Please edit the PR title

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

2017-02-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/405 @DimDroll , here's what I did to find the answer to your question: * I went to github and found https://github.com/apache/incubator-metron/blob/master/metron-deployment/packaging

[GitHub] incubator-metron issue #406: METRON-642: Correted path to ES gc log file

2017-02-24 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/406 +1 This is a correct and badly needed fix. @DimDroll (Dima), thanks for progressing this. @dlyle65535 , note this is one of the fixes also suggested in PR#425, contributed

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-17 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 Hi @JonZeolla , thanks for taking a look amidst the other demands on your time. I disagree with 'mv $fullpath/site.xml.bak $fullpath/site.xml' for the following reasons

[GitHub] incubator-metron pull request #454: METRON-716 site-book README.md

2017-02-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/454#discussion_r100912086 --- Diff: site-book/README.md --- @@ -0,0 +1,51 @@ +# Site Book Metron documentation --- End diff -- Suggest "Metron

[GitHub] incubator-metron pull request #454: METRON-716 site-book README.md

2017-02-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/454#discussion_r100912944 --- Diff: site-book/README.md --- @@ -0,0 +1,51 @@ +# Site Book Metron documentation + +Metron's Site Book is an attempt

[GitHub] incubator-metron pull request #454: METRON-716 site-book README.md

2017-02-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/454#discussion_r100910894 --- Diff: site-book/README.md --- @@ -0,0 +1,51 @@ +# Site Book Metron documentation + +Metron's Site Book is an attempt

[GitHub] incubator-metron pull request #454: METRON-716 site-book README.md

2017-02-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/454#discussion_r100911935 --- Diff: site-book/README.md --- @@ -0,0 +1,51 @@ +# Site Book Metron documentation + +Metron's Site Book is an attempt

[GitHub] incubator-metron pull request #454: METRON-716 site-book README.md

2017-02-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/454#discussion_r100938289 --- Diff: site-book/README.md --- @@ -0,0 +1,50 @@ +# Metron Site-Book documentation + +Metron's Site Book is an attempt

[GitHub] incubator-metron issue #447: METRON-708: Update metron documentation

2017-02-10 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/447 +1 on the changes so far, by inspection. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #454: METRON-716 site-book README.md

2017-02-14 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/454 +1 More than okay! This is great, thanks for doing it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-metron pull request #451: METRON-157: Added CEF Parser

2017-02-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/451#discussion_r101203282 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/utils/DateUtils.java --- @@ -0,0 +1,78

[GitHub] incubator-metron pull request #455: METRON-720 modify generate-md.sh to re-t...

2017-02-15 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/455 METRON-720 modify generate-md.sh to re-throw errors from within 'find' This patch also fixes, en passant: METRON-719 use of quadruple back-ticks in README.md file which

[GitHub] incubator-metron pull request #418: METRON-666 Fix javadoc doclint errors

2017-01-17 Thread mattf-horton
Github user mattf-horton closed the pull request at: https://github.com/apache/incubator-metron/pull/418 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron pull request #418: METRON-666 Fix javadoc doclint errors

2017-01-17 Thread mattf-horton
GitHub user mattf-horton reopened a pull request: https://github.com/apache/incubator-metron/pull/418 METRON-666 Fix javadoc doclint errors Fixes for Java 8 javadocs automatic doclint problems: - replaced many uses of `` and `` with simple uses of `` - wrapped uses

[GitHub] incubator-metron issue #418: METRON-666 Fix javadoc doclint errors

2017-01-17 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/418 Kicking Travis. Bad Travis! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request #418: METRON-666 Fix javadoc doclint errors

2017-01-17 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/418 METRON-666 Fix javadoc doclint errors Fixes for Java 8 javadocs automatic doclint problems: - replaced many uses of `` and `` with simple uses of `` - wrapped uses

[GitHub] incubator-metron issue #345: METRON-532 Define Profile Period When Calling P...

2016-11-07 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/345 Apologies, but I'm going to be offline for a couple days, due to a surgery. I will fix this when I get back. --Matt --- If your project is set up for it, you can reply to this email

[GitHub] incubator-metron pull request #345: METRON-532 Define Profile Period When Ca...

2016-11-06 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/345 METRON-532 Define Profile Period When Calling PROFILE_GET This PR builds on top of @nickwallen 's work in METRON-529, which has already been committed to master. It adds an optional

[GitHub] incubator-metron pull request #343: METRON-548 Improve Profiler documentatio...

2016-11-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/343#discussion_r86649631 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -210,78 +293,52 @@ This creates a profile... * Adds the `length` field from

[GitHub] incubator-metron pull request #343: METRON-548 Improve Profiler documentatio...

2016-11-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/343#discussion_r86649179 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -81,21 +139,46 @@ One or more expressions executed when a message is applied

[GitHub] incubator-metron pull request #343: METRON-548 Improve Profiler documentatio...

2016-11-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/343#discussion_r86648252 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -1,16 +1,74 @@ # Metron Profiler -The Profiler is a feature

[GitHub] incubator-metron pull request #343: METRON-548 Improve Profiler documentatio...

2016-11-04 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/343#discussion_r86647954 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -1,16 +1,74 @@ # Metron Profiler -The Profiler is a feature

[GitHub] incubator-metron pull request #308: Metron-498 Grok patterns are now read fr...

2016-10-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/308#discussion_r83505093 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/interfaces/MessageParser.java --- @@ -34,15 +34,15

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r83523155 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/utils/SyslogUtilsTest.java --- @@ -0,0 +1,61

[GitHub] incubator-metron pull request #308: Metron-498 Grok patterns are now read fr...

2016-10-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/308#discussion_r83513633 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/interfaces/MessageParser.java --- @@ -34,15 +34,15

[GitHub] incubator-metron issue #308: Metron-498 Grok patterns are now read from zook...

2016-10-19 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/308 Ah, that makes sense -- although I would have called it "timestampFieldName" :-) +1. I think it's ready to go, and a great piece of work! Thanks for all you

[GitHub] incubator-metron pull request #308: Metron-498 Grok patterns are now read fr...

2016-10-19 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/308#discussion_r84110876 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java --- @@ -181,7 +185,8 @@ public void

[GitHub] incubator-metron pull request #308: Metron-498 Grok patterns are now read fr...

2016-10-18 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/308#discussion_r83980978 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java --- @@ -181,7 +185,8 @@ public void

[GitHub] incubator-metron issue #362: METRON-575 State from different profiles can be...

2016-11-18 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/362 I would recommend using ordinary time units (seconds, minutes, hours, days) rather than a number of periods, for the TTL. This puts the lifetime info in one place instead of two

[GitHub] incubator-metron issue #345: METRON-532 Define Profile Period When Calling P...

2016-11-11 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/345 Thanks @cestella and @nickwallen . Suggestion implemented. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-metron pull request #334: METRON-529 Allow Configurable Periods fo...

2016-11-02 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/334#discussion_r86208152 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -226,14

[GitHub] incubator-metron pull request #334: METRON-529 Allow Configurable Periods fo...

2016-11-02 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/334#discussion_r86190240 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -226,14

[GitHub] incubator-metron pull request #334: METRON-529 Allow Configurable Periods fo...

2016-11-02 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/334#discussion_r86208554 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -226,14

[GitHub] incubator-metron issue #334: METRON-529 Allow Configurable Periods for Profi...

2016-11-02 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/334 I'm now a strong +1 on this (by inspection), subject to the usual tests. Really important piece of work, kudos to Nick! --- If your project is set up for it, you can reply

[GitHub] incubator-metron pull request #334: METRON-529 Allow Configurable Periods fo...

2016-11-01 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/334#discussion_r85995235 --- Diff: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/ProfileWriter.java --- @@ -95,4 +102,22

[GitHub] incubator-metron pull request #334: METRON-529 Allow Configurable Periods fo...

2016-11-01 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/334#discussion_r85994108 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -226,14

[GitHub] incubator-metron pull request #334: METRON-529 Allow Configurable Periods fo...

2016-11-01 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/334#discussion_r86030164 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -219,9 +219,11 @@ The Profiler topology also accepts the following configuration

[GitHub] incubator-metron pull request #334: METRON-529 Allow Configurable Periods fo...

2016-11-01 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/334#discussion_r86025730 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -226,14

[GitHub] incubator-metron pull request #334: METRON-529 Allow Configurable Periods fo...

2016-11-01 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/334#discussion_r8604 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -226,14

[GitHub] incubator-metron pull request #334: METRON-529 Allow Configurable Periods fo...

2016-11-01 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/334#discussion_r86029925 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -82,19

[GitHub] incubator-metron pull request #334: METRON-529 Allow Configurable Periods fo...

2016-11-01 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/334#discussion_r86043584 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -82,19

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-10-13 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/276 I added a comment above, to SyslogUtils.java line 36, which the system did not email to the list, probably because I immediately edited it to fix a format error. @kylerichardson

[GitHub] incubator-metron pull request #308: Metron-498 Grok patterns are now read fr...

2016-10-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/308#discussion_r83283132 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/interfaces/MessageParser.java --- @@ -34,15 +34,15

[GitHub] incubator-metron pull request #308: Metron-498 Grok patterns are now read fr...

2016-10-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/308#discussion_r83277025 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/GrokParser.java --- @@ -150,8 +149,8 @@ public void init

[GitHub] incubator-metron pull request #308: Metron-498 Grok patterns are now read fr...

2016-10-13 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/308#discussion_r83276073 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/GrokParser.java --- @@ -132,8 +130,9 @@ public void init

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-16 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r83572123 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/utils/SyslogUtilsTest.java --- @@ -0,0 +1,61

[GitHub] incubator-metron issue #188: METRON-227 (Time based flushing)

2016-10-12 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/188 -1. Upon closer review, I find that there is no timer thread or similar mechanism implemented in this patch. Thus, the patch only works if there is a steady trickle of new tuples

[GitHub] incubator-metron pull request #308: Metron-498 Grok patterns are now read fr...

2016-10-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/308#discussion_r83462598 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/GrokParser.java --- @@ -150,8 +149,8 @@ public void init

[GitHub] incubator-metron pull request #308: Metron-498 Grok patterns are now read fr...

2016-10-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/308#discussion_r83480785 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/interfaces/MessageParser.java --- @@ -34,15 +34,15

[GitHub] incubator-metron pull request #308: Metron-498 Grok patterns are now read fr...

2016-10-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/308#discussion_r83489303 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/interfaces/MessageParser.java --- @@ -34,15 +34,15

[GitHub] incubator-metron issue #413: METRON-654 Create RPM Installer for Profiler

2017-01-11 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/413 +1 Used these RPMs to add Profiler, after installing a single-node Centos7 vm with the Ambari mpack, using OracleJDK8, HDP-2.5.3, and Ambari-2.4.2. Performed `rpm -ivh metron

[GitHub] incubator-metron pull request #403: METRON-640: Add a Stellar function to co...

2017-01-10 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/403#discussion_r95462455 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/dsl/functions/StringFunctionsTest.java --- @@ -32,124 +33,143

[GitHub] incubator-metron pull request #414: Metron-532 Define Profile Period When Ca...

2017-01-09 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/414 Metron-532 Define Profile Period When Calling PROFILE_GET This PR builds on top of @nickwallen 's work in METRON-529, which has already been committed to master. It adds an optional

[GitHub] incubator-metron issue #414: METRON-532 Define Profile Period When Calling P...

2017-01-11 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/414 A further comment on multiple optional parameters: C++ allows multiple optional (defaulted) arguments, and does not support named arguments. The rule "if a later optiona

[GitHub] incubator-metron issue #414: METRON-532 Define Profile Period When Calling P...

2017-01-11 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/414 @cestella , Everlasting? Really? :-) Considering that Java doesn't, and even most interpreted languages that do support them added them as a 2nd or 3rd generation feature, I'd say

  1   2   >