Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/188
Opened https://issues.apache.org/jira/browse/INFRA-12959 for Apache Infra
to close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user james-sirota commented on the issue:
https://github.com/apache/incubator-metron/pull/188
I agree on the -1. There are additionally merge conflicts now with this
pull request and I don't believe it's worthwhile to do the merge and change the
implementation. It's easier to
Github user mattf-horton commented on the issue:
https://github.com/apache/incubator-metron/pull/188
-1. Upon closer review, I find that there is no timer thread or similar
mechanism implemented in this patch. Thus, the patch only works if there is a
steady trickle of new tuples to
Github user mmiklavc commented on the issue:
https://github.com/apache/incubator-metron/pull/188
Any new comments or actions for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/188
There is one downside that I see, but I think it's acceptable. We
currently keep configuration around the indexing in zookeeper so that the
topology configuration can be adjusted on the
Github user mmiklavc commented on the issue:
https://github.com/apache/incubator-metron/pull/188
It is a much simpler design and it leverages Storm's built-in mechanisms
for performing actions like DB flushes. Also, you don't have to worry about
multi-threading in your bolt if you
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/188
@mmiklavc That is absolutely what the tick tuple was designed for. What are
the pro/con versus the current proposed approach?
---
If your project is set up for it, you can reply to this
Github user mmiklavc commented on the issue:
https://github.com/apache/incubator-metron/pull/188
How about using Storm's built-in tick tuples for this?
https://groups.google.com/forum/#!msg/storm-user/8addaQm3OT4/0OQfSgQkRwEJ
---
If your project is set up for it, you can
Github user ajayydv commented on the issue:
https://github.com/apache/incubator-metron/pull/188
added test case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/188
Whoops, forgot, we should probably have a unit test addition given this
functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/188
Great contribution, thanks! I had a few comments, but good job. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
11 matches
Mail list logo
