[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-12-05 Thread justinleet
Github user justinleet commented on the issue:

https://github.com/apache/incubator-metron/pull/378
  
Travis errors unrelated and fixed by 
https://github.com/apache/incubator-metron/pull/383


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-12-01 Thread nickwallen
Github user nickwallen commented on the issue:

https://github.com/apache/incubator-metron/pull/378
  
Thanks @justinleet.  I do not see anything you've done here that would 
cause any problems.  

I am able to fairly reliably reproduce the bug from METRON-597 when run in 
Travis CI.  So maybe this isn't more likely to happen with the changes that 
you've made, than any others.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-30 Thread justinleet
Github user justinleet commented on the issue:

https://github.com/apache/incubator-metron/pull/378
  
@nickwallen This seems to pretty consistently failing the 
ProfilerIntegrationTest on Travis (not local, unfortunately), if you're looking 
for something seemingly repeatable.

Could you glance at this to see if I'm doing something that has an 
unexpected affect on the test? All I've really done is bumped the 
maven-jar-plugin version, removed an unrelated dependency, and migrated from a 
deprecated variable in an unrelated pom.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-30 Thread justinleet
Github user justinleet commented on the issue:

https://github.com/apache/incubator-metron/pull/378
  
This still runs locally, and appears to just incredibly unluckily be 
breaking.  If this one fails, I'm going to wait to pull in 
https://github.com/apache/incubator-metron/pull/380.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-30 Thread justinleet
Github user justinleet commented on the issue:

https://github.com/apache/incubator-metron/pull/378
  
Kicking Travis due to https://issues.apache.org/jira/browse/METRON-597


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-29 Thread dlyle65535
Github user dlyle65535 commented on the issue:

https://github.com/apache/incubator-metron/pull/378
  
No objections- a caveat though. I was referring to the changes you made 
around the maven-jar-plugin, which now that I typed it I realize is a plugin, 
so please %s/dependency/plugin my earlier comment. That said, if you want to 
open a JIRA for the pom refactoring, that'd be great! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-29 Thread justinleet
Github user justinleet commented on the issue:

https://github.com/apache/incubator-metron/pull/378
  
On the dependency versioning, it is a good idea to use the 
dependencyManagement section, but I'd probably consider that cleanup out of 
scope for this ticket. I didn't want to start a larger refactor here, just 
clear out the warnings.

On point two, it's related, but different.  We should fix our issues with 
that (to see them run ```mvn dependency:analyze```), then I'd be interested in 
in exactly that.  The difference is that your link covers dependency issues, 
but I'm interested in general pom issues (e.g. using the deprecated variable).

I'm also inclined to consider point two more important, partially because I 
don't want to generalize a bunch of dependencies that end up not actual being 
general anyway if they're unused. Any objections to that plan?

I'm inclined to create two follow up tickets, one for each of them.  I'm 
happy to pick up the second one, given that it's pretty related to this ticket.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-29 Thread dlyle65535
Github user dlyle65535 commented on the issue:

https://github.com/apache/incubator-metron/pull/378
  
On the warning/failure deal, does 
[this](http://maven.apache.org/plugins/maven-dependency-plugin/examples/failing-the-build-on-dependency-analysis-warnings.html)
 do what you're looking for?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #378: METRON-596 Eliminate Maven warnings from build

2016-11-29 Thread dlyle65535
Github user dlyle65535 commented on the issue:

https://github.com/apache/incubator-metron/pull/378
  
+1 (travis pending), glad to see the end of those. 
One small nit- if you find yourself doing wholesale dependency versioning, 
would you consider using the dependencyManagement section in the top-level pom? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---