[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506236#comment-17506236
]
Gary D. Gregory edited comment on FTPSERVER-506 at 3/14/22, 1:38 PM:
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated FTPSERVER-506:
--
Summary: Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs
1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506236#comment-17506236
]
Gary D. Gregory commented on FTPSERVER-506:
---
Hi All:
Version 1.2.0 still breaks binary
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated FTPSERVER-506:
--
Affects Version/s: 1.2.0
1.1.3
> Binary compatibility is
garydgregory opened a new pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12
1.2.0 vs 1.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated FTPSERVER-506:
--
Affects Version/s: 1.1.4
Summary: Binary compatibility is broken in
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506236#comment-17506236
]
Gary D. Gregory edited comment on FTPSERVER-506 at 3/14/22, 1:40 PM:
elecharny commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066857244
Hi Gary,
I'm nor sure this is a needed change. The implementation already returns an
array containing "TLSv1.2":
```
public class DefaultSslConfiguration
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506266#comment-17506266
]
Emmanuel Lécharny commented on FTPSERVER-506:
-
Hi Gary,
The 1.1.4 {{SslConfiguration}}
elecharny commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066965809
Hi @garydgregor,
sure enough, but I reversed the {{SslConfiguration}} interface to what it
was in 1.1.2, so I can't seer how 1.1.4v breaks ther binary
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506300#comment-17506300
]
Gary D. Gregory commented on FTPSERVER-506:
---
Yes, indeed, you are missing something ;)
It
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated FTPSERVER-506:
--
Affects Version/s: (was: 1.1.4)
> Binary compatibility is broken in
garydgregory commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066906102
Hello @elecharny ,
The code you quote is completely irrelevant. What matters is that a public
interface breaks binary compatibility. Since user can implement the
garydgregory edited a comment on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066906102
Hello @elecharny ,
The code you quote is completely irrelevant. What matters is that a public
interface breaks binary compatibility. Since user can implement
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506428#comment-17506428
]
Gary D. Gregory commented on FTPSERVER-506:
---
Hi [~elecharny]
Yes, flipping the committer
garydgregory commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1067086711
> Hi @garydgregor,
>
> sure enough, but I reversed the {{SslConfiguration}} interface to what it
was in 1.1.2, so I can't seer how 1.1.4v breaks ther binary
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506312#comment-17506312
]
Emmanuel Lécharny commented on FTPSERVER-506:
-
Ok get it now :-)
Sorry, the last days
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506314#comment-17506314
]
Gary D. Gregory commented on FTPSERVER-506:
---
Hi [~elecharny]
Do you want a PR to add
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506322#comment-17506322
]
Emmanuel Lécharny commented on FTPSERVER-506:
-
[~ggregory] yes, please. I have had a look
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506323#comment-17506323
]
Emmanuel Lécharny commented on FTPSERVER-506:
-
[~ggregory]Is making you a MINA committer
20 matches
Mail list logo
