[jira] [Comment Edited] (SSHD-812) support asynchronous mode for sftp subsystem

2018-04-09 Thread Guillaume Nodet (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431182#comment-16431182
 ] 

Guillaume Nodet edited comment on SSHD-812 at 4/9/18 8:35 PM:
--

I've refactored to smaller commits so that things are more obvious to check.
See https://github.com/apache/mina-sshd/pull/49

The first 3 commits could be merged without changing the logic from synchronous 
to asynchronous, they are required but they're just small refactoring.


was (Author: gnt):
I've refactored to smaller commits so that things are more obvious to check.
See https://github.com/apache/mina-sshd/pull/49

> support asynchronous mode for sftp subsystem
> 
>
> Key: SSHD-812
> URL: https://issues.apache.org/jira/browse/SSHD-812
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.7.0
> Environment: java1.8, linux
>Reporter: Zhenliang Su
>Assignee: Goldstein Lyor
>Priority: Minor
>  Labels: asynchronous, sftp
> Attachments: Main.java, doRead.png
>
>
> I used SSHD as a middleman between client and target sftp server.
> I found that, when filezilla client directly connect to the target sftp 
> server, it transfers fast. When filezilla client connect to the middleman, it 
> transfers slow.
> I analyzed the source code of 
> org.apache.sshd.server.subsystem.sftp.SftpSubsystem#doRead, and I found it 
> behaves like block mode, and client's other SSH_FXP_READ request blocked in 
> the same thread.
>  
> my middleman code:
>  [^Main.java]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (SSHD-812) support asynchronous mode for sftp subsystem

2018-04-09 Thread Guillaume Nodet (JIRA)

[ 
https://issues.apache.org/jira/browse/SSHD-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431182#comment-16431182
 ] 

Guillaume Nodet edited comment on SSHD-812 at 4/9/18 8:31 PM:
--

I've refactored to smaller commits so that things are more obvious to check.
See https://github.com/apache/mina-sshd/pull/49


was (Author: gnt):
I've refactored to smaller commits so that things are more obvious to check.

> support asynchronous mode for sftp subsystem
> 
>
> Key: SSHD-812
> URL: https://issues.apache.org/jira/browse/SSHD-812
> Project: MINA SSHD
>  Issue Type: New Feature
>Affects Versions: 1.7.0
> Environment: java1.8, linux
>Reporter: Zhenliang Su
>Assignee: Goldstein Lyor
>Priority: Minor
>  Labels: asynchronous, sftp
> Attachments: Main.java, doRead.png
>
>
> I used SSHD as a middleman between client and target sftp server.
> I found that, when filezilla client directly connect to the target sftp 
> server, it transfers fast. When filezilla client connect to the middleman, it 
> transfers slow.
> I analyzed the source code of 
> org.apache.sshd.server.subsystem.sftp.SftpSubsystem#doRead, and I found it 
> behaves like block mode, and client's other SSH_FXP_READ request blocked in 
> the same thread.
>  
> my middleman code:
>  [^Main.java]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)