[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2018-02-23 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374155#comment-16374155 ] Emmanuel Lecharny commented on DIRMINA-1057: Hi David, sorry, I'm totally under the water

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2018-02-23 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374134#comment-16374134 ] David Gibbs commented on DIRMINA-1057: -- [~elecharny] Hi Emanuel I see that 2.0.17 is complete but

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2018-01-12 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323727#comment-16323727 ] David Gibbs commented on DIRMINA-1057: -- [~elecharny] Hi Emanuel, we've been waiting with 'bated

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-16 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206198#comment-16206198 ] David Gibbs commented on DIRMINA-1057: -- Super, good news, thanks [~elecharny] and [~johnnyv] >

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-16 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205806#comment-16205806 ] Emmanuel Lecharny commented on DIRMINA-1057: It'll be in 2.0.17. I'm a bit swamped this

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-16 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205767#comment-16205767 ] David Gibbs commented on DIRMINA-1057: -- Thank you gentlemen, what are the next steps ? Will the fix

Re: [jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-14 Thread Jonathan Valliere
Yay! Thanks Emmanuel! On Sat, Oct 14, 2017 at 7:48 AM, Emmanuel Lecharny (JIRA) wrote: > > [ https://issues.apache.org/jira/browse/DIRMINA-1057?page= > com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel=16204593#comment-16204593 ] > > Emmanuel Lecharny

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-14 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204593#comment-16204593 ] Emmanuel Lecharny commented on DIRMINA-1057: Ok, I have reapplied the patch ( with a minor

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-13 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203654#comment-16203654 ] David Gibbs commented on DIRMINA-1057: -- I can try that with my new build. Will do soon. thanks >

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203637#comment-16203637 ] Jonathan Valliere commented on DIRMINA-1057: David, I ran the updated tests you provided

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-13 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203617#comment-16203617 ] David Gibbs commented on DIRMINA-1057: -- [~johnnyv] I have updated the test case in to run as an

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-11 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199971#comment-16199971 ] Emmanuel Lecharny commented on DIRMINA-1057: Hi Jonathan, I'm pretty sure I didn't see the

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-10 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199124#comment-16199124 ] Jonathan Valliere commented on DIRMINA-1057: Emmanuel, are you sure that error wasn't

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-10 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198530#comment-16198530 ] Emmanuel Lecharny commented on DIRMINA-1057: Thanks for the patch, Jonathan, I have

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-08 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196042#comment-16196042 ] David Gibbs commented on DIRMINA-1057: -- Great thanks Jonathan. I'll watch for a post on commit. I

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195937#comment-16195937 ] Jonathan Valliere commented on DIRMINA-1057: Okay, sorry for all the edits of the previous

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195839#comment-16195839 ] Jonathan Valliere commented on DIRMINA-1057: Okay, looks like I found a condition where

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195832#comment-16195832 ] David Gibbs commented on DIRMINA-1057: -- Will do. > AbstractIoSession getScheduledWriteMessages

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195829#comment-16195829 ] Jonathan Valliere commented on DIRMINA-1057: Can you check

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195828#comment-16195828 ] David Gibbs commented on DIRMINA-1057: -- Thank you Jonathan, I started investigating as it seems as

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195825#comment-16195825 ] Jonathan Valliere commented on DIRMINA-1057: Okay, I pulled the {{tag/2.0.16}} and found

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195758#comment-16195758 ] David Gibbs commented on DIRMINA-1057: -- In AbstractIoSession - the method

Re: [jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere
Emmanuel, I’m not sure my discussions is warranted inside of the ticket unless I come to some sort of conclusion. I don’t think that is true that the message is stacked in the IoProcessor Queue. @Override public void write(S session, WriteRequest writeRequest) { WriteRequestQueue

Re: [jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-06 Thread Jonathan Valliere
Additionally, moving the Queue control into the AbstractPollingIoProcessor and increasing backlog before adding to Queue and decreasing after removing will prevent the negative number race condition. On Fri, Oct 6, 2017 at 2:08 PM, Jonathan Valliere wrote: > I haven’t

Re: [jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-06 Thread Jonathan Valliere
I haven’t looked at the Mina code in a while. Looking at DefaultIoFilterChain.java under HeadFilter#filterWrite WriteRequestQueue writeRequestQueue = s.getWriteRequestQueue(); if (!s.isWriteSuspended()) { if (writeRequestQueue.isEmpty(session)) {

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-06 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194776#comment-16194776 ] Emmanuel Lecharny commented on DIRMINA-1057: There might be a race condition, where the

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-06 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194767#comment-16194767 ] David Gibbs commented on DIRMINA-1057: -- I don't think that I understand this code well but is it

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-06 Thread David Gibbs (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194603#comment-16194603 ] David Gibbs commented on DIRMINA-1057: -- Andre, how did you test this ? We think that we have the

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2016-11-30 Thread Andre Mermegas (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708962#comment-15708962 ] Andre Mermegas commented on DIRMINA-1057: - not at present. will try and produce one. >

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2016-11-29 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706818#comment-15706818 ] Emmanuel Lecharny commented on DIRMINA-1057: H, sounds like a bug. Do you have a