[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179078#comment-17179078 ] Emmanuel Lécharny commented on DIRMINA-1079: Doing it right now, after weeks of delaying my duty... > MINA fails to connect from behind a proxy if endpoint is not resolved > - > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler >Affects Versions: 2.0.16 >Reporter: Anton Novikov >Assignee: Jonathan Valliere >Priority: Major > Attachments: DIRMINA-1079.patch > > > MINA fails to connect from behind a proxy if endpoint address is not > resolved. This happens for both HTTP and SOCKS proxy and it seems that the > reason for this are typos in HttpProxyRequest and SocksProxyRequest. The > following changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} > with {{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) > {}} with {{if (adr != null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178899#comment-17178899 ] Tomasz commented on DIRMINA-1079: - [~elecharny] are you planing to release new version the patch? I am also impacted by the issue and needs to have it patched. > MINA fails to connect from behind a proxy if endpoint is not resolved > - > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler >Affects Versions: 2.0.16 >Reporter: Anton Novikov >Assignee: Jonathan Valliere >Priority: Major > Attachments: DIRMINA-1079.patch > > > MINA fails to connect from behind a proxy if endpoint address is not > resolved. This happens for both HTTP and SOCKS proxy and it seems that the > reason for this are typos in HttpProxyRequest and SocksProxyRequest. The > following changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} > with {{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) > {}} with {{if (adr != null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142677#comment-17142677 ] Rishabh Agarwal commented on DIRMINA-1079: -- Hi, is the patch ready for the use? > MINA fails to connect from behind a proxy if endpoint is not resolved > - > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler >Affects Versions: 2.0.16 >Reporter: Anton Novikov >Assignee: Jonathan Valliere >Priority: Major > Attachments: DIRMINA-1079.patch > > > MINA fails to connect from behind a proxy if endpoint address is not > resolved. This happens for both HTTP and SOCKS proxy and it seems that the > reason for this are typos in HttpProxyRequest and SocksProxyRequest. The > following changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} > with {{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) > {}} with {{if (adr != null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084726#comment-17084726 ] Emmanuel Lécharny commented on DIRMINA-1079: No, not yet. Under the water atm :/ > MINA fails to connect from behind a proxy if endpoint is not resolved > - > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler >Affects Versions: 2.0.16 >Reporter: Anton Novikov >Assignee: Jonathan Valliere >Priority: Major > Attachments: DIRMINA-1079.patch > > > MINA fails to connect from behind a proxy if endpoint address is not > resolved. This happens for both HTTP and SOCKS proxy and it seems that the > reason for this are typos in HttpProxyRequest and SocksProxyRequest. The > following changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} > with {{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) > {}} with {{if (adr != null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084208#comment-17084208 ] Jonathan Valliere commented on DIRMINA-1079: [~elecharny] did we merge this patch? > MINA fails to connect from behind a proxy if endpoint is not resolved > - > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler >Affects Versions: 2.0.16 >Reporter: Anton Novikov >Assignee: Jonathan Valliere >Priority: Major > Attachments: DIRMINA-1079.patch > > > MINA fails to connect from behind a proxy if endpoint address is not > resolved. This happens for both HTTP and SOCKS proxy and it seems that the > reason for this are typos in HttpProxyRequest and SocksProxyRequest. The > following changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} > with {{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) > {}} with {{if (adr != null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066548#comment-17066548 ] Emmanuel Lécharny commented on DIRMINA-1079: I can cut a release later this week. Pretty busy atm with family circling around me plus day job. The new normal nowadays ;-) > MINA fails to connect from behind a proxy if endpoint is not resolved > - > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler >Affects Versions: 2.0.16 >Reporter: Anton Novikov >Assignee: Jonathan Valliere >Priority: Major > Fix For: 2.0.23 > > Attachments: DIRMINA-1079.patch > > > MINA fails to connect from behind a proxy if endpoint address is not > resolved. This happens for both HTTP and SOCKS proxy and it seems that the > reason for this are typos in HttpProxyRequest and SocksProxyRequest. The > following changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} > with {{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) > {}} with {{if (adr != null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066477#comment-17066477 ] Rishabh Agarwal commented on DIRMINA-1079: -- Version 2.0.23 is not available to use. Are you planning to make version 2.0.23 available later or will fix this in next 2.0.x / 2.1.0 release? Please let me know as I am also affected by this issue. > MINA fails to connect from behind a proxy if endpoint is not resolved > - > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler >Affects Versions: 2.0.16 >Reporter: Anton Novikov >Assignee: Jonathan Valliere >Priority: Major > Fix For: 2.0.23 > > Attachments: DIRMINA-1079.patch > > > MINA fails to connect from behind a proxy if endpoint address is not > resolved. This happens for both HTTP and SOCKS proxy and it seems that the > reason for this are typos in HttpProxyRequest and SocksProxyRequest. The > following changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} > with {{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) > {}} with {{if (adr != null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395785#comment-16395785 ] Anton Novikov commented on DIRMINA-1079: Here you go: [^DIRMINA-1079.patch] > MINA fails to connect from behind a proxy if endpoint is not resolved > - > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler >Affects Versions: 2.0.16 >Reporter: Anton Novikov >Priority: Major > Attachments: DIRMINA-1079.patch > > > MINA fails to connect from behind a proxy if endpoint address is not > resolved. This happens for both HTTP and SOCKS proxy and it seems that the > reason for this are typos in HttpProxyRequest and SocksProxyRequest. The > following changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} > with {{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) > {}} with {{if (adr != null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386331#comment-16386331 ] Jonathan Valliere commented on DIRMINA-1079: Please make your suggestion as a patch created using {{git diff --patch}} > MINA fails to connect from behind a proxy if endpoint is not resolved > - > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler >Affects Versions: 2.0.16 >Reporter: Anton Novikov >Priority: Major > > MINA fails to connect from behind a proxy if endpoint address is not > resolved. This happens for both HTTP and SOCKS proxy and it seems that the > reason for this are typos in HttpProxyRequest and SocksProxyRequest. The > following changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} > with {{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) > {}} with {{if (adr != null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384750#comment-16384750 ] Anton Novikov commented on DIRMINA-1079: Yes, that's correct. And in fact the code is mostly there already, it does not work because of the conditions I suggest to correct > MINA fails to connect from behind a proxy if endpoint is not resolved > - > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler >Affects Versions: 2.0.16 >Reporter: Anton Novikov >Priority: Major > > MINA fails to connect from behind a proxy if endpoint address is not > resolved. This happens for both HTTP and SOCKS proxy and it seems that the > reason for this are typos in HttpProxyRequest and SocksProxyRequest. The > following changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} > with {{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) > {}} with {{if (adr != null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian JIRA (v7.6.3#76005)