Re: [PR] Use a singleton threadpool for kex message handler flushing [mina-sshd]
gnodet merged PR #459: URL: https://github.com/apache/mina-sshd/pull/459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [PR] Use a singleton threadpool for kex message handler flushing [mina-sshd]
FliegenKLATSCH commented on PR #459: URL: https://github.com/apache/mina-sshd/pull/459#issuecomment-1914734447 > While the task submitted in `flushQueue()` quits when a new KEX has started while flushing or when the session has been closed while flushing, I wonder if we now need something to prevent a second task being submitted by the same session before the first one has ended. Good point, I'd tend to say no because of the locking in the loop. > Should the threads be daemon threads? Actually not really, but the same is probably true for other usages as well :/ Wondering if this would be a real world issue, since implementations would anyway wait for a response. Could rather be an issue on the server side. Should we make it configurable? I am wondering if someone knows some good framework around thread pools to be used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [PR] Use a singleton threadpool for kex message handler flushing [mina-sshd]
garydgregory commented on PR #459: URL: https://github.com/apache/mina-sshd/pull/459#issuecomment-1913654972 Should the threads be daemon threads? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [PR] Use a singleton threadpool for kex message handler flushing [mina-sshd]
tomaswolf commented on PR #459: URL: https://github.com/apache/mina-sshd/pull/459#issuecomment-1913639726 While the task submitted in `flushQueue()` quits when a new KEX has started while flushing or when the session has been closed while flushing, I wonder if we now need something to prevent a second task being submitted by the same session before the first one has ended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
