Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-20 Thread Guillaume Nodet
+1 Le jeu. 12 oct. 2023 à 16:33, Guillaume Nodet a écrit : > I've staged a candidate release for 2.9.3 at: > Official staging repo: > https://dist.apache.org/repos/dist/dev/mina/sshd/2.9.3/ > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachemina-1088 > Git

Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-17 Thread Emmanuel Lécharny
Guillaume, Thomas, thanks for the feedback. Here, I think we are at a crossroad: - some of the tests are pure unit tests (and generally don't require TC) - some other tests are integration tests (and may require some more environment, which may mean TC) I understand the need of having to

Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-17 Thread Gary Gregory
I think the CI should run ALL tests. It's for the developer in a hurry to disable some tests from the command line if they want to take the chance. Gary On Tue, Oct 17, 2023, 2:04 AM Guillaume Nodet wrote: > Le lun. 16 oct. 2023 à 22:02, Thomas Wolf a écrit : > > > On 16.10.23 01:04 ,

Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-17 Thread Guillaume Nodet
Le lun. 16 oct. 2023 à 22:02, Thomas Wolf a écrit : > On 16.10.23 01:04 , Emmanuel Lécharny wrote: > > > My main concern is that we now need to install Docker to get the test > > passing, due to the usage of TestContainer. I don't really like it, the > > build should be self-supported. > > The

Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-16 Thread Thomas Wolf
On 16.10.23 01:04 , Emmanuel Lécharny wrote: My main concern is that we now need to install Docker to get the test passing, due to the usage of TestContainer. I don't really like it, the build should be self-supported. The use of TestContainers isn't new. Add to that it took 25mins to ran

Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-15 Thread Emmanuel Lécharny
Hi, My +1. I've tje sameremarks thah for the other SSHD vote. Th nks ! ! On 14/10/2023 16:10, Gary D. Gregory wrote: Hi again: I should add that there is no way that I can tell if we've broken binary compatibility (or source compatibility) since there is no use of japicmp (or revapi

Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-15 Thread Emmanuel Lécharny
Hi! My +1. - Checked the signature - Built with Java 8 - test passed green when I installed Docker My main concern is that we now need to install Docker to get the test passing, due to the usage of TestContainer. I don't really like it, the build should be self-supported. Add to that it

Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-14 Thread Gary D. Gregory
Hi again: I should add that there is no way that I can tell if we've broken binary compatibility (or source compatibility) since there is no use of japicmp (or revapi or ...) Gary On 2023/10/14 14:04:07 "Gary D. Gregory" wrote: > Hi All: > > +1 > > Lots of comments on this one; I am

Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-14 Thread Gary D. Gregory
Hi All: +1 Lots of comments on this one; I am reviewing the src zip file: - ASC OK - Can't validate SHA file with: shasum --check apache-sshd-2.9.3-src.zip.sha512 This is due to non-standard format for the file. Eyeballing the file looks OK when compared to shasum -a 512 output. -

Re: [VOTE] Release Apache Mina SSHD 2.9.3

2023-10-12 Thread Thomas Wolf
On 12.10.23 16:33 , Guillaume Nodet wrote: I've staged a candidate release for 2.9.3 at: +1 * Src tar unpacks and builds fine; all tests pass locally (OS X) * Signatures verify * Class version 52 (Java 8) Cheers, Thomas