Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-14 Thread Guillaume Nodet
+1

I'll close the vote and publish the release asap.

Guillaume

Le mar. 6 févr. 2024 à 16:34, Guillaume Nodet  a écrit :
>
> I've staged a candidate release for an SSHD bug fix 2.12.1 release at:
> Official staging repo:
>   https://dist.apache.org/repos/dist/dev/mina/sshd/2.12.1/
> Maven staging repo:
>   https://repository.apache.org/content/repositories/orgapachemina-1091
> Git tag:
>   https://github.com/apache/mina-sshd/commits/sshd-2.12.1
> Changelog:
>   https://github.com/apache/mina-sshd/blob/sshd-2.12.1/docs/changes/2.12.1.md
>
> Please review and vote !
>
> --
> 
> Guillaume Nodet



-- 

Guillaume Nodet

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-12 Thread Gary D. Gregory
+1

All is well on Windows (I'll have to deal with my macOS setup later) and 'mvn 
clean verify' using:

Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: C:\java\apache-maven-3.9.6
Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program 
Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Microsoft Windows [Version 10.0.19045.3930]

Docker version 25.0.2, build 29cf629

Gary

On 2024/02/11 14:51:03 Gary Gregory wrote:
> I'm glad it works on your end :-) Here, I made sure docker is on the PATH:
> 
> docker --version
> Docker version 25.0.3, build 4debf41
> 
> But I'm still trying to figure out why I can't get our tests to see Docker:
> 
> [ERROR] Please refer to
> /Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core/target/surefire-reports-nio2
> for the individual test results.
> [ERROR] Please refer to dump files (if any exist) [date].dump,
> [date]-jvmRun[N].dump and [date].dumpstream.
> [ERROR] The forked VM terminated without properly saying goodbye. VM
> crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd
> '/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core' &&
> '/usr/local/Cellar/openjdk@17/17.0.9/libexec/openjdk.jdk/Contents/Home/bin/java'
> '-jar' 
> '/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core/target/surefire/surefirebooter-20240211094002439_162.jar'
> '/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core/target/surefire'
> '2024-02-11T09-38-46_176-jvmRun1' 'surefire-20240211094002439_160tmp'
> 'surefire_1-20240211094002439_161tmp'
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 143
> [ERROR] Crashed tests:
> [ERROR] org.apache.sshd.client.session.ClientSessionTest
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> The forked VM terminated without properly saying goodbye. VM crash or
> System.exit called?
> [ERROR] Command was /bin/sh -c cd
> '/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core' &&
> '/usr/local/Cellar/openjdk@17/17.0.9/libexec/openjdk.jdk/Contents/Home/bin/java'
> '-jar' 
> '/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core/target/surefire/surefirebooter-20240211094002439_162.jar'
> '/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core/target/surefire'
> '2024-02-11T09-38-46_176-jvmRun1' 'surefire-20240211094002439_160tmp'
> 'surefire_1-20240211094002439_161tmp'
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 143
> [ERROR] Crashed tests:
> [ERROR] org.apache.sshd.client.session.ClientSessionTest
> [ERROR] at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:643)
> [ERROR] at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285)
> [ERROR] at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250)
> 
> I can't see anything useful in sshd-core/target/surefire-reports-nio2/
> 
> Gary
> 
> On Sun, Feb 11, 2024 at 2:45 AM Emmanuel Lécharny  wrote:
> >
> > Hi Gary,
> >
> > I have Docker 2.25.2 running on my Mac.
> >
> > $ docker ps
> > CONTAINER ID   IMAGE   COMMAND   CREATED
> > STATUS  PORTS NAMES
> > b3cfc446e8f4   testcontainers/ryuk:0.3.3   "/app"23 seconds ago   Up
> > 22 seconds   0.0.0.0:60997->8080/tcp
> > testcontainers-ryuk-6366f9f8-f922-41c8-b2b1-3e30dd1e4671
> >
> > or
> >
> > $ docker ps
> > CONTAINER ID   IMAGE
> > COMMAND  CREATED  STATUS  PORTS
> > NAMES
> > 1d69e8b3f633   localhost/testcontainers/tx3g8n6fh63vansg:latest
> > "/usr/sbin/sshd -D -…"   2 seconds agoUp 2 seconds
> > 0.0.0.0:61124->22/tcp quizzical_lederberg
> > b3cfc446e8f4   testcontainers/ryuk:0.3.3
> >
> > so basically, it works.
> >
> > It sometimes asks me for my KeyChain password.
> >
> >
> > On 10/02/2024 17:42, Gary Gregory wrote:
> > > I just updated to DD 4.27.2 (137060), it crashed on the restart and
> > > asked me to reset to factory settings, I did, then restarted DD. The
> > > UI says "engine running"
> > >
> > > run 'mvn clean verify" and the 1st reported failure is:
> > >
> > > [ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time
> > > elapsed: 0.078 s <<< FAILURE! -- in
> > > org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest
> > > [ERROR] 
> > > org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest.testPubkeyAuth[user01_rsa_sha2_512_2048]
> > > -- Time elapsed: 0.075 s <<< ERROR!
> > > java.lang.IllegalStateException: Could not find a valid Docker
> > > environment. Please see logs and check configuration
> > > at 
> > > org.testcontainers.dockerclient.DockerClientProviderStrategy.lambda$getFirstValidStrategy$4(DockerClientProviderStrategy.java:156)
> > > at java.base/java.util.Optional.orElseThrow(Optional.java:408)
> > > at 
> > > 

Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-11 Thread Gary Gregory
I'm glad it works on your end :-) Here, I made sure docker is on the PATH:

docker --version
Docker version 25.0.3, build 4debf41

But I'm still trying to figure out why I can't get our tests to see Docker:

[ERROR] Please refer to
/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core/target/surefire-reports-nio2
for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump,
[date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] The forked VM terminated without properly saying goodbye. VM
crash or System.exit called?
[ERROR] Command was /bin/sh -c cd
'/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core' &&
'/usr/local/Cellar/openjdk@17/17.0.9/libexec/openjdk.jdk/Contents/Home/bin/java'
'-jar' 
'/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core/target/surefire/surefirebooter-20240211094002439_162.jar'
'/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core/target/surefire'
'2024-02-11T09-38-46_176-jvmRun1' 'surefire-20240211094002439_160tmp'
'surefire_1-20240211094002439_161tmp'
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 143
[ERROR] Crashed tests:
[ERROR] org.apache.sshd.client.session.ClientSessionTest
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
The forked VM terminated without properly saying goodbye. VM crash or
System.exit called?
[ERROR] Command was /bin/sh -c cd
'/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core' &&
'/usr/local/Cellar/openjdk@17/17.0.9/libexec/openjdk.jdk/Contents/Home/bin/java'
'-jar' 
'/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core/target/surefire/surefirebooter-20240211094002439_162.jar'
'/Users/garydgregory/rc/mina/apache-sshd-2.12.1/sshd-core/target/surefire'
'2024-02-11T09-38-46_176-jvmRun1' 'surefire-20240211094002439_160tmp'
'surefire_1-20240211094002439_161tmp'
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 143
[ERROR] Crashed tests:
[ERROR] org.apache.sshd.client.session.ClientSessionTest
[ERROR] at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:643)
[ERROR] at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285)
[ERROR] at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250)

I can't see anything useful in sshd-core/target/surefire-reports-nio2/

Gary

On Sun, Feb 11, 2024 at 2:45 AM Emmanuel Lécharny  wrote:
>
> Hi Gary,
>
> I have Docker 2.25.2 running on my Mac.
>
> $ docker ps
> CONTAINER ID   IMAGE   COMMAND   CREATED
> STATUS  PORTS NAMES
> b3cfc446e8f4   testcontainers/ryuk:0.3.3   "/app"23 seconds ago   Up
> 22 seconds   0.0.0.0:60997->8080/tcp
> testcontainers-ryuk-6366f9f8-f922-41c8-b2b1-3e30dd1e4671
>
> or
>
> $ docker ps
> CONTAINER ID   IMAGE
> COMMAND  CREATED  STATUS  PORTS
> NAMES
> 1d69e8b3f633   localhost/testcontainers/tx3g8n6fh63vansg:latest
> "/usr/sbin/sshd -D -…"   2 seconds agoUp 2 seconds
> 0.0.0.0:61124->22/tcp quizzical_lederberg
> b3cfc446e8f4   testcontainers/ryuk:0.3.3
>
> so basically, it works.
>
> It sometimes asks me for my KeyChain password.
>
>
> On 10/02/2024 17:42, Gary Gregory wrote:
> > I just updated to DD 4.27.2 (137060), it crashed on the restart and
> > asked me to reset to factory settings, I did, then restarted DD. The
> > UI says "engine running"
> >
> > run 'mvn clean verify" and the 1st reported failure is:
> >
> > [ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time
> > elapsed: 0.078 s <<< FAILURE! -- in
> > org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest
> > [ERROR] 
> > org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest.testPubkeyAuth[user01_rsa_sha2_512_2048]
> > -- Time elapsed: 0.075 s <<< ERROR!
> > java.lang.IllegalStateException: Could not find a valid Docker
> > environment. Please see logs and check configuration
> > at 
> > org.testcontainers.dockerclient.DockerClientProviderStrategy.lambda$getFirstValidStrategy$4(DockerClientProviderStrategy.java:156)
> > at java.base/java.util.Optional.orElseThrow(Optional.java:408)
> > at 
> > org.testcontainers.dockerclient.DockerClientProviderStrategy.getFirstValidStrategy(DockerClientProviderStrategy.java:148)
> > at 
> > org.testcontainers.DockerClientFactory.getOrInitializeStrategy(DockerClientFactory.java:146)
> > at 
> > org.testcontainers.DockerClientFactory.client(DockerClientFactory.java:188)
> > at 
> > org.testcontainers.DockerClientFactory$1.getDockerClient(DockerClientFactory.java:101)
> > at 
> > com.github.dockerjava.api.DockerClientDelegate.authConfig(DockerClientDelegate.java:107)
> > at 
> > org.testcontainers.containers.GenericContainer.start(GenericContainer.java:316)
> > at 
> > org.testcontainers.containers.GenericContainer.starting(GenericContainer.java:1066)
> > at 
> > 

Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-10 Thread Emmanuel Lécharny

Hi Gary,

I have Docker 2.25.2 running on my Mac.

$ docker ps
CONTAINER ID   IMAGE   COMMAND   CREATED 
STATUS  PORTS NAMES
b3cfc446e8f4   testcontainers/ryuk:0.3.3   "/app"23 seconds ago   Up 
22 seconds   0.0.0.0:60997->8080/tcp 
testcontainers-ryuk-6366f9f8-f922-41c8-b2b1-3e30dd1e4671


or

$ docker ps
CONTAINER ID   IMAGE 
COMMAND  CREATED  STATUS  PORTS 
   NAMES
1d69e8b3f633   localhost/testcontainers/tx3g8n6fh63vansg:latest 
"/usr/sbin/sshd -D -…"   2 seconds agoUp 2 seconds 
0.0.0.0:61124->22/tcp quizzical_lederberg

b3cfc446e8f4   testcontainers/ryuk:0.3.3

so basically, it works.

It sometimes asks me for my KeyChain password.


On 10/02/2024 17:42, Gary Gregory wrote:

I just updated to DD 4.27.2 (137060), it crashed on the restart and
asked me to reset to factory settings, I did, then restarted DD. The
UI says "engine running"

run 'mvn clean verify" and the 1st reported failure is:

[ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time
elapsed: 0.078 s <<< FAILURE! -- in
org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest
[ERROR] 
org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest.testPubkeyAuth[user01_rsa_sha2_512_2048]
-- Time elapsed: 0.075 s <<< ERROR!
java.lang.IllegalStateException: Could not find a valid Docker
environment. Please see logs and check configuration
at 
org.testcontainers.dockerclient.DockerClientProviderStrategy.lambda$getFirstValidStrategy$4(DockerClientProviderStrategy.java:156)
at java.base/java.util.Optional.orElseThrow(Optional.java:408)
at 
org.testcontainers.dockerclient.DockerClientProviderStrategy.getFirstValidStrategy(DockerClientProviderStrategy.java:148)
at 
org.testcontainers.DockerClientFactory.getOrInitializeStrategy(DockerClientFactory.java:146)
at org.testcontainers.DockerClientFactory.client(DockerClientFactory.java:188)
at 
org.testcontainers.DockerClientFactory$1.getDockerClient(DockerClientFactory.java:101)
at 
com.github.dockerjava.api.DockerClientDelegate.authConfig(DockerClientDelegate.java:107)
at 
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:316)
at 
org.testcontainers.containers.GenericContainer.starting(GenericContainer.java:1066)
at 
org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:29)

I must be missing some requirements. The 'docker' app is not on my
PATH. Is it on yours? Can you say 'docker ps' for example?

Gary

On Sat, Feb 10, 2024 at 11:32 AM Gary Gregory  wrote:


Hi Emmanuel:

Yes: Docker Desktop 4.27.1 (136059)

Gary

On Sat, Feb 10, 2024 at 11:25 AM Emmanuel Lécharny  wrote:


Hi Gary,

I had it working on my Mac, have you docker running before launching the
test?

On 10/02/2024 04:10, Gary Gregory wrote:

Testing src zip file.

- ASC OK
- Eyeballing SHA512 is OK but can't be checked with "shasum --check
apache-sshd-2.12.1-src.zip.sha512"
- On macOS, with Docker running, the tests can't find it or download
an image, if that's what it is trying to do:
[ERROR] Errors:
[ERROR] 
org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest.testPubkeyAuth[user01_ecdsa_256]
[ERROR]   Run 1:
HostBoundPubKeyAuthTest.testPubkeyAuth[user01_ecdsa_256] »
IllegalState Previous attempts to find a Docker environment failed.
Will not retry. Please see logs and check configuration

This is with both Java 17 and 11.

Any ideas?

Gary


On Tue, Feb 6, 2024 at 10:35 AM Guillaume Nodet  wrote:


I've staged a candidate release for an SSHD bug fix 2.12.1 release at:
Official staging repo:
https://dist.apache.org/repos/dist/dev/mina/sshd/2.12.1/
Maven staging repo:
https://repository.apache.org/content/repositories/orgapachemina-1091
Git tag:
https://github.com/apache/mina-sshd/commits/sshd-2.12.1
Changelog:
https://github.com/apache/mina-sshd/blob/sshd-2.12.1/docs/changes/2.12.1.md

Please review and vote !

--

Guillaume Nodet

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



--
*Emmanuel Lécharny* P. +33 (0)6 08 33 32 61
elecha...@apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



--
*Emmanuel Lécharny* P. +33 (0)6 08 33 32 61
elecha...@apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-10 Thread Gary Gregory
I just updated to DD 4.27.2 (137060), it crashed on the restart and
asked me to reset to factory settings, I did, then restarted DD. The
UI says "engine running"

run 'mvn clean verify" and the 1st reported failure is:

[ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time
elapsed: 0.078 s <<< FAILURE! -- in
org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest
[ERROR] 
org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest.testPubkeyAuth[user01_rsa_sha2_512_2048]
-- Time elapsed: 0.075 s <<< ERROR!
java.lang.IllegalStateException: Could not find a valid Docker
environment. Please see logs and check configuration
at 
org.testcontainers.dockerclient.DockerClientProviderStrategy.lambda$getFirstValidStrategy$4(DockerClientProviderStrategy.java:156)
at java.base/java.util.Optional.orElseThrow(Optional.java:408)
at 
org.testcontainers.dockerclient.DockerClientProviderStrategy.getFirstValidStrategy(DockerClientProviderStrategy.java:148)
at 
org.testcontainers.DockerClientFactory.getOrInitializeStrategy(DockerClientFactory.java:146)
at org.testcontainers.DockerClientFactory.client(DockerClientFactory.java:188)
at 
org.testcontainers.DockerClientFactory$1.getDockerClient(DockerClientFactory.java:101)
at 
com.github.dockerjava.api.DockerClientDelegate.authConfig(DockerClientDelegate.java:107)
at 
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:316)
at 
org.testcontainers.containers.GenericContainer.starting(GenericContainer.java:1066)
at 
org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:29)

I must be missing some requirements. The 'docker' app is not on my
PATH. Is it on yours? Can you say 'docker ps' for example?

Gary

On Sat, Feb 10, 2024 at 11:32 AM Gary Gregory  wrote:
>
> Hi Emmanuel:
>
> Yes: Docker Desktop 4.27.1 (136059)
>
> Gary
>
> On Sat, Feb 10, 2024 at 11:25 AM Emmanuel Lécharny  
> wrote:
> >
> > Hi Gary,
> >
> > I had it working on my Mac, have you docker running before launching the
> > test?
> >
> > On 10/02/2024 04:10, Gary Gregory wrote:
> > > Testing src zip file.
> > >
> > > - ASC OK
> > > - Eyeballing SHA512 is OK but can't be checked with "shasum --check
> > > apache-sshd-2.12.1-src.zip.sha512"
> > > - On macOS, with Docker running, the tests can't find it or download
> > > an image, if that's what it is trying to do:
> > > [ERROR] Errors:
> > > [ERROR] 
> > > org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest.testPubkeyAuth[user01_ecdsa_256]
> > > [ERROR]   Run 1:
> > > HostBoundPubKeyAuthTest.testPubkeyAuth[user01_ecdsa_256] »
> > > IllegalState Previous attempts to find a Docker environment failed.
> > > Will not retry. Please see logs and check configuration
> > >
> > > This is with both Java 17 and 11.
> > >
> > > Any ideas?
> > >
> > > Gary
> > >
> > >
> > > On Tue, Feb 6, 2024 at 10:35 AM Guillaume Nodet  wrote:
> > >>
> > >> I've staged a candidate release for an SSHD bug fix 2.12.1 release at:
> > >> Official staging repo:
> > >>https://dist.apache.org/repos/dist/dev/mina/sshd/2.12.1/
> > >> Maven staging repo:
> > >>https://repository.apache.org/content/repositories/orgapachemina-1091
> > >> Git tag:
> > >>https://github.com/apache/mina-sshd/commits/sshd-2.12.1
> > >> Changelog:
> > >>
> > >> https://github.com/apache/mina-sshd/blob/sshd-2.12.1/docs/changes/2.12.1.md
> > >>
> > >> Please review and vote !
> > >>
> > >> --
> > >> 
> > >> Guillaume Nodet
> > >>
> > >> -
> > >> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> > >> For additional commands, e-mail: dev-h...@mina.apache.org
> > >>
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> > > For additional commands, e-mail: dev-h...@mina.apache.org
> > >
> >
> > --
> > *Emmanuel Lécharny* P. +33 (0)6 08 33 32 61
> > elecha...@apache.org
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> > For additional commands, e-mail: dev-h...@mina.apache.org
> >

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-10 Thread Gary Gregory
Hi Emmanuel:

Yes: Docker Desktop 4.27.1 (136059)

Gary

On Sat, Feb 10, 2024 at 11:25 AM Emmanuel Lécharny  wrote:
>
> Hi Gary,
>
> I had it working on my Mac, have you docker running before launching the
> test?
>
> On 10/02/2024 04:10, Gary Gregory wrote:
> > Testing src zip file.
> >
> > - ASC OK
> > - Eyeballing SHA512 is OK but can't be checked with "shasum --check
> > apache-sshd-2.12.1-src.zip.sha512"
> > - On macOS, with Docker running, the tests can't find it or download
> > an image, if that's what it is trying to do:
> > [ERROR] Errors:
> > [ERROR] 
> > org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest.testPubkeyAuth[user01_ecdsa_256]
> > [ERROR]   Run 1:
> > HostBoundPubKeyAuthTest.testPubkeyAuth[user01_ecdsa_256] »
> > IllegalState Previous attempts to find a Docker environment failed.
> > Will not retry. Please see logs and check configuration
> >
> > This is with both Java 17 and 11.
> >
> > Any ideas?
> >
> > Gary
> >
> >
> > On Tue, Feb 6, 2024 at 10:35 AM Guillaume Nodet  wrote:
> >>
> >> I've staged a candidate release for an SSHD bug fix 2.12.1 release at:
> >> Official staging repo:
> >>https://dist.apache.org/repos/dist/dev/mina/sshd/2.12.1/
> >> Maven staging repo:
> >>https://repository.apache.org/content/repositories/orgapachemina-1091
> >> Git tag:
> >>https://github.com/apache/mina-sshd/commits/sshd-2.12.1
> >> Changelog:
> >>
> >> https://github.com/apache/mina-sshd/blob/sshd-2.12.1/docs/changes/2.12.1.md
> >>
> >> Please review and vote !
> >>
> >> --
> >> 
> >> Guillaume Nodet
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> >> For additional commands, e-mail: dev-h...@mina.apache.org
> >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> > For additional commands, e-mail: dev-h...@mina.apache.org
> >
>
> --
> *Emmanuel Lécharny* P. +33 (0)6 08 33 32 61
> elecha...@apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> For additional commands, e-mail: dev-h...@mina.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-10 Thread Emmanuel Lécharny

Hi Gary,

I had it working on my Mac, have you docker running before launching the 
test?


On 10/02/2024 04:10, Gary Gregory wrote:

Testing src zip file.

- ASC OK
- Eyeballing SHA512 is OK but can't be checked with "shasum --check
apache-sshd-2.12.1-src.zip.sha512"
- On macOS, with Docker running, the tests can't find it or download
an image, if that's what it is trying to do:
[ERROR] Errors:
[ERROR] 
org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest.testPubkeyAuth[user01_ecdsa_256]
[ERROR]   Run 1:
HostBoundPubKeyAuthTest.testPubkeyAuth[user01_ecdsa_256] »
IllegalState Previous attempts to find a Docker environment failed.
Will not retry. Please see logs and check configuration

This is with both Java 17 and 11.

Any ideas?

Gary


On Tue, Feb 6, 2024 at 10:35 AM Guillaume Nodet  wrote:


I've staged a candidate release for an SSHD bug fix 2.12.1 release at:
Official staging repo:
   https://dist.apache.org/repos/dist/dev/mina/sshd/2.12.1/
Maven staging repo:
   https://repository.apache.org/content/repositories/orgapachemina-1091
Git tag:
   https://github.com/apache/mina-sshd/commits/sshd-2.12.1
Changelog:
   https://github.com/apache/mina-sshd/blob/sshd-2.12.1/docs/changes/2.12.1.md

Please review and vote !

--

Guillaume Nodet

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



--
*Emmanuel Lécharny* P. +33 (0)6 08 33 32 61
elecha...@apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-09 Thread Gary Gregory
Testing src zip file.

- ASC OK
- Eyeballing SHA512 is OK but can't be checked with "shasum --check
apache-sshd-2.12.1-src.zip.sha512"
- On macOS, with Docker running, the tests can't find it or download
an image, if that's what it is trying to do:
[ERROR] Errors:
[ERROR] 
org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest.testPubkeyAuth[user01_ecdsa_256]
[ERROR]   Run 1:
HostBoundPubKeyAuthTest.testPubkeyAuth[user01_ecdsa_256] »
IllegalState Previous attempts to find a Docker environment failed.
Will not retry. Please see logs and check configuration

This is with both Java 17 and 11.

Any ideas?

Gary


On Tue, Feb 6, 2024 at 10:35 AM Guillaume Nodet  wrote:
>
> I've staged a candidate release for an SSHD bug fix 2.12.1 release at:
> Official staging repo:
>   https://dist.apache.org/repos/dist/dev/mina/sshd/2.12.1/
> Maven staging repo:
>   https://repository.apache.org/content/repositories/orgapachemina-1091
> Git tag:
>   https://github.com/apache/mina-sshd/commits/sshd-2.12.1
> Changelog:
>   https://github.com/apache/mina-sshd/blob/sshd-2.12.1/docs/changes/2.12.1.md
>
> Please review and vote !
>
> --
> 
> Guillaume Nodet
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> For additional commands, e-mail: dev-h...@mina.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-08 Thread Guillaume Nodet
Le jeu. 8 févr. 2024 à 03:08, Emmanuel Lécharny  a écrit :
>
> Hi,
>
> built from the distribution:
> - once docker is launched,

Yes, i've been hit by that one more than once.
There's a no-containers-for-windows profile (which is automatically
activated on windows) and which disables
tests that use docker.   I think we should fail fast if this profile
is not enabled and no docker env is available (and maybe rename it as
it would not be windows specific).

> - and Java 11 used
> got it to work.
>
> The README stipulate that Java 8+ is required, the tests are faiking
> with Java 8.

The build time and run time requirements may differ.  The target JDK
is still 1.8.
Fwiw, I've just run a full build of the source release archive with
JDK 8 (docker enabled of course).

> There are a lot of files in sshd-sources and docs that have no AL.2.0
> headers, so rat is failing when ran.

The rat plugin is part of the build, but those files are excluded from
the check.
See https://github.com/apache/mina-sshd/blob/master/pom.xml#L718-L757
I don't think the files in sshd-sources are used in the build, so
maybe we should  get rid of those. They were added as part of
https://issues.apache.org/jira/browse/SSHD-914 4 or 5 years ago but
never touched since...

Guillaume

>
> On 06/02/2024 16:34, Guillaume Nodet wrote:
> > I've staged a candidate release for an SSHD bug fix 2.12.1 release at:
> > Official staging repo:
> >https://dist.apache.org/repos/dist/dev/mina/sshd/2.12.1/
> > Maven staging repo:
> >https://repository.apache.org/content/repositories/orgapachemina-1091
> > Git tag:
> >https://github.com/apache/mina-sshd/commits/sshd-2.12.1
> > Changelog:
> >
> > https://github.com/apache/mina-sshd/blob/sshd-2.12.1/docs/changes/2.12.1.md
> >
> > Please review and vote !
> >
>
> --
> *Emmanuel Lécharny* P. +33 (0)6 08 33 32 61
> elecha...@apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> For additional commands, e-mail: dev-h...@mina.apache.org
>


--

Guillaume Nodet

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [VOTE] Release Mina SSHD 2.12.1

2024-02-07 Thread Emmanuel Lécharny

Hi,

built from the distribution:
- once docker is launched,
- and Java 11 used
got it to work.

The README stipulate that Java 8+ is required, the tests are faiking 
with Java 8.


There are a lot of files in sshd-sources and docs that have no AL.2.0 
headers, so rat is failing when ran.


On 06/02/2024 16:34, Guillaume Nodet wrote:

I've staged a candidate release for an SSHD bug fix 2.12.1 release at:
Official staging repo:
   https://dist.apache.org/repos/dist/dev/mina/sshd/2.12.1/
Maven staging repo:
   https://repository.apache.org/content/repositories/orgapachemina-1091
Git tag:
   https://github.com/apache/mina-sshd/commits/sshd-2.12.1
Changelog:
   https://github.com/apache/mina-sshd/blob/sshd-2.12.1/docs/changes/2.12.1.md

Please review and vote !



--
*Emmanuel Lécharny* P. +33 (0)6 08 33 32 61
elecha...@apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org